From: "Aníbal Monsalve Salazar" <anibal@debian.org>
To: linux-nfs@vger.kernel.org
Subject: [PATCH] nfsidmap: Don't check ENABLE_LDAP twice
Date: Sun, 26 May 2013 08:02:17 +1000 [thread overview]
Message-ID: <20130525220217.GA4330@master.debian.org> (raw)
To build the Debian libnfsidmap package, I've used the patch in this
mail for more than a year.
Debian-BTS: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661215
Author: Steve Langasek <steve.langasek@ubuntu.com>
Description: Don't check ENABLE_LDAP twice
This source is already being conditionally compiled based on ENABLE_LDAP
being set in the Makefile. All this extra check does is cause umich_ldap.so
to always be compiled as an *EMPTY* object because nothing sets ENABLE_LDAP
before the #ifdef!
Bug-Ubuntu: https://bugs.launchpad.net/bugs/939232
diff -up a/umich_ldap.c b/umich_ldap.c
--- a/umich_ldap.c 2011-12-06 07:28:10.000000000 +1100
+++ b/umich_ldap.c 2012-02-27 13:21:34.000000000 +1100
@@ -32,8 +32,6 @@
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifdef ENABLE_LDAP
-
#include <sys/types.h>
#include <sys/socket.h>
#include <netdb.h>
@@ -1302,4 +1300,3 @@ struct trans_func *libnfsidmap_plugin_in
{
return (&umichldap_trans);
}
-#endif
next reply other threads:[~2013-05-25 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 22:02 Aníbal Monsalve Salazar [this message]
2013-05-28 18:01 ` [PATCH] nfsidmap: Don't check ENABLE_LDAP twice Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130525220217.GA4330@master.debian.org \
--to=anibal@debian.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.