Re: [PATCH v3 2/6] mm/memory_hotplug: remove memory_add_physaddr_to_nid

[Wanpeng Li <liwanp@linux.vnet.ibm.com>]

On Sun, May 26, 2013 at 10:59:38AM +0200, Michal Hocko wrote:
>On Sun 26-05-13 13:58:37, Wanpeng Li wrote:
>> memory_add_physaddr_to_nid is not used any more, this patch remove it.
>
>git grep disagrees.
>git grep "= *\<memory_add_physaddr_to_nid\>" mmotm
>mmotm:drivers/acpi/acpi_memhotplug.c:                   node = memory_add_physaddr_to_nid(info->start_addr);
>mmotm:drivers/acpi/acpi_memhotplug.c:                   nid = memory_add_physaddr_to_nid(info->start_addr);
>mmotm:drivers/base/memory.c:            nid = memory_add_physaddr_to_nid(phys_addr);
>mmotm:drivers/xen/balloon.c:    nid = memory_add_physaddr_to_nid(hotplug_start_paddr);
>

Oh, sorry, I make a mistake here. 

>> 
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>> ---
>>  arch/x86/mm/numa.c | 15 ---------------
>>  1 file changed, 15 deletions(-)
>> 
>> diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
>> index a71c4e2..d470a54 100644
>> --- a/arch/x86/mm/numa.c
>> +++ b/arch/x86/mm/numa.c
>> @@ -803,18 +803,3 @@ const struct cpumask *cpumask_of_node(int node)
>>  EXPORT_SYMBOL(cpumask_of_node);
>>  
>>  #endif	/* !CONFIG_DEBUG_PER_CPU_MAPS */
>> -
>> -#ifdef CONFIG_MEMORY_HOTPLUG
>> -int memory_add_physaddr_to_nid(u64 start)
>> -{
>> -	struct numa_meminfo *mi = &numa_meminfo;
>> -	int nid = mi->blk[0].nid;
>> -	int i;
>> -
>> -	for (i = 0; i < mi->nr_blks; i++)
>> -		if (mi->blk[i].start <= start && mi->blk[i].end > start)
>> -			nid = mi->blk[i].nid;
>> -	return nid;
>> -}
>> -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid);
>> -#endif
>> -- 
>> 1.8.1.2
>> 
>
>-- 
>Michal Hocko
>SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>