From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code
Date: Sun, 26 May 2013 20:51:10 +0300 [thread overview]
Message-ID: <20130526175110.GA3115@redhat.com> (raw)
In-Reply-To: <CAFEAcA9stW6xv3mr0ouMVTcDfVE=4=_OcUuZscguJkzGFY9WKg@mail.gmail.com>
On Sun, May 26, 2013 at 04:43:57PM +0100, Peter Maydell wrote:
> On 26 May 2013 16:22, Michael S. Tsirkin <mst@redhat.com> wrote:
> > virtio linux headers are actually pretty portable:
> > all we need is implement linux/types.h in a portable
> > way, and we can import them and use on any platform.
> >
> > These patches do exactly that, as a pre-requisite
> > to adding support for new virtio layout.
> >
> > Note: if someone adds non-portable code in files we import from linux-headers,
> > we'll have to revert to copying code manually. This didn't happen yet so
> > hopefully it won't.
>
> This series breaks compilation on MacOSX:
>
> CC net/eth.o
> In file included from net/eth.c:18:
> In file included from /Users/pm215/src/qemu/include/net/eth.h:29:
> /Users/pm215/src/qemu/linux-headers/linux/if_ether.h:24:10: fatal
> error: 'linux/types.h' file not found
> #include <linux/types.h>
> ^
> 1 error generated.
> make: *** [net/eth.o] Error 1
>
> thanks
> -- PMM
Could be a stale file in your tree ...
Did configure get re-run?
Could you post the config-host.mak file please?
next prev parent reply other threads:[~2013-05-26 17:51 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 15:22 [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code Michael S. Tsirkin
2013-05-26 15:22 ` [Qemu-devel] [PATCH v2 01/11] make: pull in linux-headers on all platforms Michael S. Tsirkin
2013-05-26 15:22 ` [Qemu-devel] [PATCH v2 02/11] scripts/update-linux-headers.sh: add virtio Michael S. Tsirkin
2013-05-26 15:22 ` [Qemu-devel] [PATCH v2 03/11] virtio-9p: switch to linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 04/11] virtio-net, eth: use linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 05/11] virtio-blk: switch to linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 06/11] virtio-balloon: " Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 07/11] virtio-rng: " Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 08/11] virtio-console: " Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 09/11] virtio: add virtio_ids from linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 10/11] virtio-pci: switch to linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 11/11] virtio: use ring structure from linux-headers Michael S. Tsirkin
2013-05-26 15:43 ` [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code Peter Maydell
2013-05-26 17:51 ` Michael S. Tsirkin [this message]
2013-05-26 18:00 ` Peter Maydell
2013-05-26 18:10 ` Michael S. Tsirkin
2013-05-26 18:26 ` Paolo Bonzini
2013-05-26 18:37 ` Michael S. Tsirkin
2013-05-26 18:53 ` Paolo Bonzini
2013-05-26 20:02 ` Michael S. Tsirkin
2013-05-26 20:20 ` Paolo Bonzini
2013-05-26 20:49 ` Anthony Liguori
2013-05-26 20:49 ` Anthony Liguori
2013-05-26 21:42 ` Michael S. Tsirkin
2013-05-26 21:42 ` Michael S. Tsirkin
2013-05-27 0:55 ` Anthony Liguori
2013-05-27 0:55 ` Anthony Liguori
2013-05-27 15:02 ` Michael S. Tsirkin
2013-05-27 15:02 ` Michael S. Tsirkin
2013-05-27 16:14 ` Anthony Liguori
2013-05-27 16:14 ` Anthony Liguori
2013-05-28 6:23 ` Michael S. Tsirkin
2013-05-28 6:23 ` Michael S. Tsirkin
2013-05-29 0:14 ` Rusty Russell
2013-05-29 13:05 ` Anthony Liguori
2013-05-29 14:09 ` Michael S. Tsirkin
2013-05-29 14:09 ` Michael S. Tsirkin
2013-05-29 14:58 ` Anthony Liguori
2013-05-29 14:58 ` Anthony Liguori
2013-05-27 11:15 ` Rusty Russell
2013-05-28 2:55 ` Anthony Liguori
2013-05-29 0:17 ` Rusty Russell
2013-05-29 0:17 ` Rusty Russell
2013-05-29 5:17 ` Bryan Venteicher
2013-05-29 5:17 ` Bryan Venteicher
2013-05-27 10:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130526175110.GA3115@redhat.com \
--to=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.