All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code
Date: Sun, 26 May 2013 23:02:51 +0300	[thread overview]
Message-ID: <20130526200251.GA4305@redhat.com> (raw)
In-Reply-To: <51A25A2D.8030700@redhat.com>

On Sun, May 26, 2013 at 08:53:33PM +0200, Paolo Bonzini wrote:
> Il 26/05/2013 20:37, Michael S. Tsirkin ha scritto:
> >> > I don't like defining __-prefixed types.  Can we preprocess
> >> > linux-headers to avoid usage of __u8/16/32/64, and to
> >> > s,linux/types.h,stdint.h, ?
> >> > 
> >> > Paolo
> > Let's not be purists, and do the practical thing.
> > 
> > When I suggested this you didn't like it:
> >>> >> I can think of two ways:
> >>> >>     - strip linux/types.h in update_headers
> >>> >>     - add a stub linux/types.h for non linux platforms
> >> >
> >> >The latter, using stdint.h types, would be fine.
> 
> My fault.  I should have looked at linux/types.h (actually asm-generic/).
> 
> Paolo

Not really, __uX appear in the headers that were posted.
What I'm saying is - a chance of a conflict is very remote,
if it happens it's a build failure so easy to debug.

-- 
MST

  reply	other threads:[~2013-05-26 20:02 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-26 15:22 [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code Michael S. Tsirkin
2013-05-26 15:22 ` [Qemu-devel] [PATCH v2 01/11] make: pull in linux-headers on all platforms Michael S. Tsirkin
2013-05-26 15:22 ` [Qemu-devel] [PATCH v2 02/11] scripts/update-linux-headers.sh: add virtio Michael S. Tsirkin
2013-05-26 15:22 ` [Qemu-devel] [PATCH v2 03/11] virtio-9p: switch to linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 04/11] virtio-net, eth: use linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 05/11] virtio-blk: switch to linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 06/11] virtio-balloon: " Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 07/11] virtio-rng: " Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 08/11] virtio-console: " Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 09/11] virtio: add virtio_ids from linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 10/11] virtio-pci: switch to linux-headers Michael S. Tsirkin
2013-05-26 15:23 ` [Qemu-devel] [PATCH v2 11/11] virtio: use ring structure from linux-headers Michael S. Tsirkin
2013-05-26 15:43 ` [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code Peter Maydell
2013-05-26 17:51   ` Michael S. Tsirkin
2013-05-26 18:00     ` Peter Maydell
2013-05-26 18:10       ` Michael S. Tsirkin
2013-05-26 18:26         ` Paolo Bonzini
2013-05-26 18:37           ` Michael S. Tsirkin
2013-05-26 18:53             ` Paolo Bonzini
2013-05-26 20:02               ` Michael S. Tsirkin [this message]
2013-05-26 20:20                 ` Paolo Bonzini
2013-05-26 20:49                   ` Anthony Liguori
2013-05-26 20:49                     ` Anthony Liguori
2013-05-26 21:42                     ` Michael S. Tsirkin
2013-05-26 21:42                       ` Michael S. Tsirkin
2013-05-27  0:55                       ` Anthony Liguori
2013-05-27  0:55                         ` Anthony Liguori
2013-05-27 15:02                         ` Michael S. Tsirkin
2013-05-27 15:02                           ` Michael S. Tsirkin
2013-05-27 16:14                           ` Anthony Liguori
2013-05-27 16:14                             ` Anthony Liguori
2013-05-28  6:23                             ` Michael S. Tsirkin
2013-05-28  6:23                               ` Michael S. Tsirkin
2013-05-29  0:14                             ` Rusty Russell
2013-05-29 13:05                               ` Anthony Liguori
2013-05-29 14:09                                 ` Michael S. Tsirkin
2013-05-29 14:09                                   ` Michael S. Tsirkin
2013-05-29 14:58                                   ` Anthony Liguori
2013-05-29 14:58                                     ` Anthony Liguori
2013-05-27 11:15                     ` Rusty Russell
2013-05-28  2:55                       ` Anthony Liguori
2013-05-29  0:17                         ` Rusty Russell
2013-05-29  0:17                         ` Rusty Russell
2013-05-29  5:17                       ` Bryan Venteicher
2013-05-29  5:17                       ` Bryan Venteicher
2013-05-27 10:19         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130526200251.GA4305@redhat.com \
    --to=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.