From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Chen Gang <gang.chen@asianux.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
Greg KH <gregkh@linuxfoundation.org>,
zhangyanfei@cn.fujitsu.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] arch: x86: platform: mrst: pr_err() need notice that 'sdev->modalias' may not a NUL terminated string.
Date: Mon, 27 May 2013 09:06:35 +0200 [thread overview]
Message-ID: <20130527070634.GA1494@breakpoint.cc> (raw)
In-Reply-To: <51A1CCCE.1020103@asianux.com>
On Sun, May 26, 2013 at 04:50:22PM +0800, Chen Gang wrote:
>
> According to the areas which use "%16.16s" within this file, the
> 'sdev->modalias' may not always be a NUL terminated string.
>
> So need use "%.16s" instead of "%s" in pr_err(), or may cause issue.
No. spi_match_id() expects a NULL terminated string and I would be suprised if
it would be otherwise. Therefore moorsetown or this files has to learn to NULL
terminate its strings.
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Sebastian
next prev parent reply other threads:[~2013-05-27 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 8:50 [PATCH] arch: x86: platform: mrst: pr_err() need notice that 'sdev->modalias' may not a NUL terminated string Chen Gang
2013-05-27 7:06 ` Sebastian Andrzej Siewior [this message]
2013-05-27 8:16 ` Chen Gang
2013-05-27 8:16 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130527070634.GA1494@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=gang.chen@asianux.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.