From: Vinod Koul <vinod.koul@intel.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawn.guo@linaro.org, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate
Date: Mon, 27 May 2013 15:36:26 +0530 [thread overview]
Message-ID: <20130527100626.GB30200@intel.com> (raw)
In-Reply-To: <1369424247-12439-1-git-send-email-festevam@gmail.com>
On Fri, May 24, 2013 at 04:37:27PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Fix the following sparse warning:
>
> drivers/dma/mxs-dma.c:696:17: warning: symbol 'mxs_dma_xlate' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, Thanks
--
~Vinod
> ---
> drivers/dma/mxs-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index b48a79c..7195930 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -693,7 +693,7 @@ static bool mxs_dma_filter_fn(struct dma_chan *chan, void *fn_param)
> return true;
> }
>
> -struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
> +static struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
> struct of_dma *ofdma)
> {
> struct mxs_dma_engine *mxs_dma = ofdma->of_dma_data;
> --
> 1.8.1.2
>
prev parent reply other threads:[~2013-05-27 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 19:37 [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate Fabio Estevam
2013-05-27 7:07 ` Shawn Guo
2013-05-27 10:06 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130527100626.GB30200@intel.com \
--to=vinod.koul@intel.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.