From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftables PATCH 2/2] src: xml: add versioning
Date: Mon, 27 May 2013 14:51:09 +0200 [thread overview]
Message-ID: <20130527125109.GB16382@localhost> (raw)
In-Reply-To: <20130524112846.13209.99752.stgit@nfdev.cica.es>
On Fri, May 24, 2013 at 01:28:46PM +0200, Arturo Borrero wrote:
> All XML chunks now have a "version" attribute to help in future changes.
>
> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> ---
> include/libnftables/chain.h | 2 ++
> include/libnftables/rule.h | 2 ++
> include/libnftables/table.h | 2 ++
> src/chain.c | 18 +++++++++++++++---
> src/rule.c | 17 +++++++++++++++--
> src/table.c | 18 ++++++++++++++++--
> 6 files changed, 52 insertions(+), 7 deletions(-)
>
> diff --git a/include/libnftables/chain.h b/include/libnftables/chain.h
> index b12474f..a789e8b 100644
> --- a/include/libnftables/chain.h
> +++ b/include/libnftables/chain.h
> @@ -45,6 +45,8 @@ enum {
> NFT_CHAIN_O_XML,
> };
>
> +#define NFT_CHAIN_XML_VERSION 0
This definition is only used internally, so it should not be exported.
Move it to internal.h.
prev parent reply other threads:[~2013-05-27 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 11:28 [libnftables PATCH 0/2] small fixes for libnftables XML Arturo Borrero
2013-05-24 11:28 ` [libnftables PATCH 1/2] src: chain: delete useless castings Arturo Borrero
2013-05-27 12:47 ` Pablo Neira Ayuso
2013-05-24 11:28 ` [libnftables PATCH 2/2] src: xml: add versioning Arturo Borrero
2013-05-27 12:51 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130527125109.GB16382@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.