From: Baruch Siach <baruch@tkos.co.il>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] clocksource: dw_apb: fix error check
Date: Mon, 27 May 2013 16:49:10 +0300 [thread overview]
Message-ID: <20130527134910.GU5037@tarshish> (raw)
In-Reply-To: <51A35C2F.4000201@linaro.org>
Hi Daniel,
On Mon, May 27, 2013 at 03:14:23PM +0200, Daniel Lezcano wrote:
> On 05/27/2013 01:51 PM, Baruch Siach wrote:
> > irq_of_parse_and_map() returns 0 on error, while the code checks for NO_IRQ.
> > This breaks on platforms that have NO_IRQ != 0.
> >
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
>
> Shouldn't the 'irq_of_parse_and_map' function to be fixed and return
> NO_IRQ in case of error ? (even if some code checks the return value is
> 'zero' in case of error [1], while some other code checks NO_IRQ [2]).
Probably not. See http://lwn.net/Articles/470820/.
baruch
> [1]
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/x86/kernel/devicetree.c#n124
>
> [2]
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/sysdev/fsl_msi.c#n344
>
>
> > drivers/clocksource/dw_apb_timer_of.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c
> > index 9fdb4d3..843d43b 100644
> > --- a/drivers/clocksource/dw_apb_timer_of.c
> > +++ b/drivers/clocksource/dw_apb_timer_of.c
> > @@ -47,7 +47,7 @@ static void add_clockevent(struct device_node *event_timer)
> > u32 irq, rate;
> >
> > irq = irq_of_parse_and_map(event_timer, 0);
> > - if (irq == NO_IRQ)
> > + if (irq == 0)
> > panic("No IRQ for clock event timer");
> >
> > timer_get_base_and_rate(event_timer, &iobase, &rate);
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2013-05-27 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 11:51 [PATCH] clocksource: dw_apb: fix error check Baruch Siach
2013-05-27 13:14 ` Daniel Lezcano
2013-05-27 13:49 ` Baruch Siach [this message]
2013-05-27 14:27 ` Daniel Lezcano
2013-05-29 8:22 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130527134910.GU5037@tarshish \
--to=baruch@tkos.co.il \
--cc=daniel.lezcano@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.