From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq Date: Mon, 27 May 2013 16:13:06 +0200 Message-ID: <20130527141306.GS24476@game.jcrosoft.org> References: <1369571337-9300-1-git-send-email-plagnioj@jcrosoft.com> <51A25ECA.2060001@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <51A25ECA.2060001@cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sergei Shtylyov Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-mmc@vger.kernel.org On 23:13 Sun 26 May , Sergei Shtylyov wrote: > Hello. > > On 05/26/2013 04:28 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > >set missing irq type the IRQF_ONESHOT > > > >Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > >Cc: stable # 3.4+ > >Cc: linux-mmc@vger.kernel.org > >--- > > drivers/mmc/host/of_mmc_spi.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c > >index d720b5e..cfb2e61 100644 > >--- a/drivers/mmc/host/of_mmc_spi.c > >+++ b/drivers/mmc/host/of_mmc_spi.c > >@@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev, > > { > > struct of_mmc_spi *oms = to_of_mmc_spi(dev); > >- return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0, > >- dev_name(dev), mmc); > >+ return request_threaded_irq(oms->detect_irq, NULL, irqhandler, > >+ IRQF_ONESHOT, dev_name(dev), mmc); > > Please don't change the indentation. too long > 80 Best Regards, J. From mboxrd@z Thu Jan 1 00:00:00 1970 From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD) Date: Mon, 27 May 2013 16:13:06 +0200 Subject: [PATCH 1/1] mmc: of_mmc_spi: fix card detect irq In-Reply-To: <51A25ECA.2060001@cogentembedded.com> References: <1369571337-9300-1-git-send-email-plagnioj@jcrosoft.com> <51A25ECA.2060001@cogentembedded.com> Message-ID: <20130527141306.GS24476@game.jcrosoft.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 23:13 Sun 26 May , Sergei Shtylyov wrote: > Hello. > > On 05/26/2013 04:28 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > >set missing irq type the IRQF_ONESHOT > > > >Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > >Cc: stable # 3.4+ > >Cc: linux-mmc at vger.kernel.org > >--- > > drivers/mmc/host/of_mmc_spi.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c > >index d720b5e..cfb2e61 100644 > >--- a/drivers/mmc/host/of_mmc_spi.c > >+++ b/drivers/mmc/host/of_mmc_spi.c > >@@ -74,8 +74,8 @@ static int of_mmc_spi_init(struct device *dev, > > { > > struct of_mmc_spi *oms = to_of_mmc_spi(dev); > >- return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0, > >- dev_name(dev), mmc); > >+ return request_threaded_irq(oms->detect_irq, NULL, irqhandler, > >+ IRQF_ONESHOT, dev_name(dev), mmc); > > Please don't change the indentation. too long > 80 Best Regards, J.