From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftables PATCH] data_reg: fix XML operations
Date: Mon, 27 May 2013 20:59:58 +0200 [thread overview]
Message-ID: <20130527185958.GA27839@localhost> (raw)
In-Reply-To: <20130527171654.4585.61260.stgit@nfdev.cica.es>
Hi Arturo,
On Mon, May 27, 2013 at 07:16:54PM +0200, Arturo Borrero wrote:
> Several fixes:
>
> * Conditional XML code for snprintf_xml.
> I don't think that not having XML support breaks XML printing.
>
> * Add generic interface for parsing: nft_data_reg_parse().
> Simply missing in previous patches.
>
> * Fix conditional code in XML parsing functions.
> All the XML parsing chunk was conditional but the main function. I think is better to
> do the conditional compilation by function, returning -1 and setting errno = EOPNOTSUPP.
>
> * Delete trailing space in snprintf_xml " >"
I cannot take a patch with four fixes. You have to split them, one for
each. Sorry.
prev parent reply other threads:[~2013-05-27 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 17:16 [libnftables PATCH] data_reg: fix XML operations Arturo Borrero
2013-05-27 18:59 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130527185958.GA27839@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.