All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Keeping <john@keeping.me.uk>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: git <git@vger.kernel.org>
Subject: Re: git-send-email doesn't deal with quoted names
Date: Tue, 28 May 2013 09:25:17 +0100	[thread overview]
Message-ID: <20130528082517.GP27005@serenity.lan> (raw)
In-Reply-To: <CAHmME9p19eysjEVk+6FmAb2FQb7dq_e3k_KLQLRZqhx2Bs6O3w@mail.gmail.com>

On Tue, May 28, 2013 at 01:40:20AM +0200, Jason A. Donenfeld wrote:
> My commit author name is "Jason A. Donenfeld". Because this has a dot,
> SMTP handling likes to put it in quotes.
> 
> git-send-email has this line:
>             if (defined $author and $author ne $sender) {
> 
> With my name, this always winds up false, because it's comparing
> '"Jason A. Donenfeld" <Jason@zx2c4.com>' with 'Jason A. Donenfeld
> <Jason@zx2c4.com>'.
> 
> So, the logic needs to be fixed somehow.

There was a patch for this recently, although it appears to be still
under discussion:

    http://article.gmane.org/gmane.comp.version-control.git/225247

      reply	other threads:[~2013-05-28  8:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27 23:40 git-send-email doesn't deal with quoted names Jason A. Donenfeld
2013-05-28  8:25 ` John Keeping [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130528082517.GP27005@serenity.lan \
    --to=john@keeping.me.uk \
    --cc=Jason@zx2c4.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.