From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [BUG] xen-kbdfront.c Date: Tue, 28 May 2013 10:41:20 -0400 Message-ID: <20130528144120.GO724@phenom.dumpdata.com> References: <20130527111315.GM11427@reaktio.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20130527111315.GM11427@reaktio.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= Cc: Dominic Russell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, May 27, 2013 at 02:13:15PM +0300, Pasi K=E4rkk=E4inen wrote: > On Sun, May 26, 2013 at 05:12:54PM -0400, Dominic Russell wrote: > > Hello, > > = > > By trying to find a workaround for the mouse =E2**unsync=E2** in VNC= , I > > noticed that the mouse, even if the resolution has been changed by a > > .video argument on the kernel, was only moving in a 800x600 window. > > = > > It must be due to those lines of code in xen-kbdfront.c (taken from > > kernel-3.9.1) : > > = > > input_set_abs_params(ptr, ABS_X, 0, XENFB_WIDTH, 0, 0); > > input_set_abs_params(ptr, ABS_Y, 0, XENFB_HEIGHT, 0, 0); > > = > > If the resolution has been overridden by a kernel argument, the widt= h and > > height should be taken from those arguments also, not from the > > constants... > > = > = > Feel free to send a patch :) > = > http://wiki.xen.org/wiki/Submitting_Xen_Patches That does look like a bug. And to further compound it - the xen-fbfront is the one for which the 'video' parameters are altered. Which means that = xen-fbfront needs to export said parameter so that xen-kbdfront can use it. Yikes. Oh, great: 133 /* = = 134 * Wart: xenkbd needs to know default resolution. Put it here until a = = 135 * better solution is found, but don't leak it to the backend. = = 136 */ = Wart indeed. Dominic, would you be interested in making a patch for this? The one mechan= ism by which I think this might work is by = 1). changing 'video' in the xen-fbfront to 'xenfb_video' to at least not co= nflict with other symbols 2). make it an EXPORT_SYMBOL_GPL 3). stick the structure (video) in a the fbif.h and also the decleration. 4). use that in xen-kbdfront. 5). fiddle with the Kconfig file as need to make xen-kbdfornt depends on xe= n-fbfront. > = > -- Pasi > = > = > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > =