All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arturo Borrero <arturo.borrero.glez@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: [libnftables PATCH] rule: fix table flag not being set at XML parsing
Date: Tue, 28 May 2013 17:06:08 +0200	[thread overview]
Message-ID: <20130528150608.5236.81847.stgit@nfdev.cica.es> (raw)

This bug was introduced by me at commit:

	'src: add support for XML parsing'
	51370f0eedb1c8167ab2c340d2a53f0d9f02509c

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 src/rule.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/rule.c b/src/rule.c
index 318ae07..4d56d5a 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -479,6 +479,7 @@ static int nft_rule_xml_parse(struct nft_rule *r, char *xml)
 		free(r->table);
 
 	r->table = strdup(mxmlElementGetAttr(tree, "table"));
+	r->flags |= (1 << NFT_RULE_ATTR_TABLE);
 
 	/* get and set <rule ... chain=X ...> */
 	if (mxmlElementGetAttr(tree, "chain") == NULL) {


             reply	other threads:[~2013-05-28 15:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28 15:06 Arturo Borrero [this message]
2013-05-29 12:11 ` [libnftables PATCH] rule: fix table flag not being set at XML parsing Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130528150608.5236.81847.stgit@nfdev.cica.es \
    --to=arturo.borrero.glez@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.