From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 01/12] batman-adv: implement batadv_tt_entries
Date: Tue, 28 May 2013 15:25:49 +0800 [thread overview]
Message-ID: <201305281525.49326.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1369683792-531-2-git-send-email-ordex@autistici.org>
On Tuesday, May 28, 2013 03:43:01 Antonio Quartulli wrote:
> +/**
> + * batadv_tt_entries - compute the number of entries fitting in tt_len
> bytes + * @tt_len: available space
> + *
> + * Return the number of entries.
> + */
> +static uint16_t batadv_tt_entries(uint16_t tt_len)
> +{
> + return tt_len / sizeof(struct batadv_tvlv_tt_change);
> +}
For the sake of consistency, wouldn't it be better to call batadv_tt_len(1)
instead of sizeof(struct batadv_tvlv_tt_change) ?
Cheers,
Marek
next prev parent reply other threads:[~2013-05-28 7:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 19:43 [B.A.T.M.A.N.] [PATCHv3 00/12] make the Translation Table component VLAN-aware Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 01/12] batman-adv: implement batadv_tt_entries Antonio Quartulli
2013-05-28 7:25 ` Marek Lindner [this message]
2013-05-28 7:49 ` Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 02/12] batman-adv: make batadv_tt_save_orig_buffer() generic Antonio Quartulli
2013-05-28 7:30 ` Marek Lindner
2013-05-28 7:49 ` Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 03/12] batman-adv: add the VLAN ID attribute to the TT entry Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 04/12] batman-adv: use vid when computing local and global TT CRC Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 05/12] batman-adv: print the VID together with the TT entries Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 06/12] batman-adv: make the GW module correctly talk to the new VLAN-TT Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 07/12] batman-adv: make the Distributed ARP Table vlan aware Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 08/12] batman-adv: add per VLAN interface attribute framework Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 09/12] batman-adv: make the AP isolation attribute VLAN specific Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 10/12] batman-adv: make the backbone gw check " Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 11/12] batman-adv: make the TT global purge routine " Antonio Quartulli
2013-05-27 19:43 ` [B.A.T.M.A.N.] [PATCHv3 12/12] batman-adv: make the TT CRC logic " Antonio Quartulli
2013-06-04 7:18 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305281525.49326.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.