From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Matt Fleming <matt@console-pimps.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Matt Fleming <matt.fleming@intel.com>,
Seth Forshee <seth.forshee@canonical.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] x86/PCI: setup data may be in highmem
Date: Tue, 28 May 2013 17:48:01 +0100 [thread overview]
Message-ID: <20130528164801.GA2345@srcf.ucam.org> (raw)
In-Reply-To: <CAErSpo5DG61wvQEw_9z8vm6Lp=E0urq6LG5SOuWSawkNeDkF+A@mail.gmail.com>
On Tue, May 28, 2013 at 10:31:51AM -0600, Bjorn Helgaas wrote:
> On Tue, May 28, 2013 at 5:36 AM, Matt Fleming <matt@console-pimps.org> wrote:
> > On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote:
> >> pcibios_add_device() is mostly called at boot-time, when
> >> early_ioremap() probably works well. But it's also called when we
> >> hot-add devices later, and it looks like early_ioremap() will then
> >> generate warnings because "system_state != SYSTEM_BOOTING".
> >
> > Oops. Good point. Is there any reason we can't use ioremap()?
>
> I assume Matthew had some reason for avoiding that in the first place,
> so I hope he'll chime in.
I have no recollection of why I did it that way. If this is all
happening late enough for ioremap() to work then that sounds fine.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-05-28 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 9:43 [PATCH] x86/PCI: setup data may be in highmem Matt Fleming
2013-05-23 22:46 ` H. Peter Anvin
2013-05-24 14:38 ` Bjorn Helgaas
2013-05-28 11:36 ` Matt Fleming
2013-05-28 16:31 ` Bjorn Helgaas
2013-05-28 16:48 ` Matthew Garrett [this message]
2013-05-28 17:28 ` Bjorn Helgaas
2013-06-05 14:15 ` Matt Fleming
2013-06-05 17:10 ` Bjorn Helgaas
2013-06-08 11:15 ` Artem Bityutskiy
2013-06-08 11:14 ` Bityutskiy, Artem
2013-06-08 11:14 ` Bityutskiy, Artem
2013-06-08 11:14 ` Bityutskiy, Artem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528164801.GA2345@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=bhelgaas@google.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=seth.forshee@canonical.com \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.