All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Mark Brown <broonie@kernel.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	alsa-devel@alsa-project.org,
	Dong Aisheng <dong.aisheng@linaro.org>,
	Eric Nelson <eric.nelson@boundarydevices.com>
Subject: Re: [PATCH] ASoC: sgtl5000: Fix VAG_POWER enabling/disabling order
Date: Tue, 28 May 2013 20:57:30 +0200	[thread overview]
Message-ID: <201305282057.30204.marex@denx.de> (raw)
In-Reply-To: <20130528145943.GS21462@opensource.wolfsonmicro.com>

Dear Mark Brown,

> On Fri, May 24, 2013 at 05:34:56AM +0200, Marek Vasut wrote:
> > -	case SND_SOC_DAPM_POST_PMD:
> > 
> > +	case SND_SOC_DAPM_PRE_PMD:
> >  		snd_soc_update_bits(w->codec, SGTL5000_CHIP_ANA_POWER,
> >  		
> >  			SGTL5000_VAG_POWERUP, 0);
> > 
> > -		msleep(400);
> > +		mdelay(400);
> > 
> >  		break;
> 
> This looks to be both unrelated and a regression - mdelay() should be
> more resource intensive than sleeping and if it's 400ms we shouldn't be
> that worried about delaying slightly longer.

Definitelly, this was not supposed to be part of the patch. Fixed in V2.

> Please note my updated mail address which I've been using for a while
> now, the Wolfson one will go bad at the end of the week.

Roger. I hope you have a good time at your new position :)

Best regards,
Marek Vasut

      reply	other threads:[~2013-05-28 18:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  3:34 [PATCH] ASoC: sgtl5000: Fix VAG_POWER enabling/disabling order Marek Vasut
2013-05-28 14:10 ` Fabio Estevam
2013-05-28 18:23   ` Marek Vasut
2013-05-28 19:44     ` Fabio Estevam
2013-05-28 20:04       ` Marek Vasut
2013-05-28 14:59 ` Mark Brown
2013-05-28 18:57   ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305282057.30204.marex@denx.de \
    --to=marex@denx.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dong.aisheng@linaro.org \
    --cc=eric.nelson@boundarydevices.com \
    --cc=fabio.estevam@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.