All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Hahn <hahn@univention.de>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [BUG, PATCH] xen-4.1-3 xend/XendDomainInfo.py#device_configure() TypeError
Date: Wed, 29 May 2013 07:47:11 +0200	[thread overview]
Message-ID: <201305290747.11406.hahn@univention.de> (raw)
In-Reply-To: <20130528152552.GA4695@phenom.dumpdata.com>

Hello,

Am Dienstag 28 Mai 2013, 17:25:52 schrieben Sie:
> >     def _getDeviceInfo_vbd(self, devid):
> >         for dev_type, dev_info in self.info.all_devices_sxpr()
...
> >                 return dev_info
> 
> Ewwww, that looks buggy. Could you just do 'return dev' ?

I don't think that this would be correct, since dev and devid are just the device numbers, but dev_info contains the device details  as an Sxpr:
devid='768'
dev='hda:cdrom' ... dev='hda' ... dev=768
dev_type='vbd'
dev_info=['vbd', ('uuid', '920a5c24-28c6-6abb-ad47-9c1144012986'), ('bootable', 1), ('driver', 'paravirtualised'), ('dev', 'hda:cdrom'), ('uname', 'file:/var/lib/libvirt/images/UCS_3.1-1-amd64.iso'), ('mode', 'r'), ('VDI', ''), ('backend', 0)]

So chaning the return type of the function with the name _get*DeviceInfo* look wrong. Or am I missing something?

Sincerely
Philipp
-- 
Philipp Hahn           Open Source Software Engineer      hahn@univention.de
Univention GmbH        be open.                       fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
                                                   http://www.univention.de/

  reply	other threads:[~2013-05-29  5:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24 17:53 [BUG, PATCH] xen-4.1-3 xend/XendDomainInfo.py#device_configure() TypeError Philipp Hahn
2013-05-28 15:25 ` Konrad Rzeszutek Wilk
2013-05-29  5:47   ` Philipp Hahn [this message]
2013-06-05 18:52     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305290747.11406.hahn@univention.de \
    --to=hahn@univention.de \
    --cc=konrad.wilk@oracle.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.