From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
nf-devel <netfilter-devel@vger.kernel.org>
Subject: Re: nfqueue: detect when packet has already been checksummed?
Date: Wed, 29 May 2013 15:25:37 +0200 [thread overview]
Message-ID: <20130529132537.GH6578@breakpoint.cc> (raw)
In-Reply-To: <20130529122328.GA6286@localhost>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Yes, but this looks like abuse of the flag semantics to me.
> > Unless you mean that setting this feat flag should prompt the kernel
> > to explicitly call a valiation function in case skb_csum_unnecessary()
> > returns false?
>
> I mean exactly the current behaviour but forcing user-space to ask for
> it. So skb info flag regarding checksumming comes from kernel if
> explicitly requested from user-space.
Fair enough, I can resubmit this for -next with this behaviour,
I had hoped to avoid a new flag, since there is no reason for it
OTHER than to figure out if the kernel knows about that checksumming
feature.
prev parent reply other threads:[~2013-05-29 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 20:48 nfqueue: detect when packet has already been checksummed? Florian Westphal
2013-05-26 20:48 ` [PATCH] netfilter: nf_queue: add NFQA_SKB_CSUM_NOTVERIFIED info flag Florian Westphal
2013-06-29 12:45 ` Pablo Neira Ayuso
2013-05-29 11:14 ` nfqueue: detect when packet has already been checksummed? Pablo Neira Ayuso
2013-05-29 11:25 ` Florian Westphal
2013-05-29 11:57 ` Pablo Neira Ayuso
2013-05-29 12:03 ` Florian Westphal
2013-05-29 12:23 ` Pablo Neira Ayuso
2013-05-29 13:25 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529132537.GH6578@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.