From: Stephen Hemminger <stephen@networkplumber.org>
To: Mike Rapoport <mike.rapoport@ravellosystems.com>
Cc: netdev@vger.kernel.org, Thomas Graf <tgraf@suug.ch>
Subject: Re: [PATCH net-next v3 1/2] vxlan: introduce vxlan_rdst_append
Date: Wed, 29 May 2013 15:56:42 -0700 [thread overview]
Message-ID: <20130529155642.391b50b3@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1369821617-29098-2-git-send-email-mike.rapoport@ravellosystems.com>
On Wed, 29 May 2013 13:00:15 +0300
Mike Rapoport <mike.rapoport@ravellosystems.com> wrote:
> -/* Add/update destinations for multicast */
> -static int vxlan_fdb_append(struct vxlan_fdb *f,
> - __be32 ip, __be16 port, __u32 vni, __u32 ifindex)
> +static int vxlan_rdst_append(struct vxlan_rdst *rdst, __be32 ip, __be16 port,
> + __u32 vni, __u32 ifindex)
> {
> struct vxlan_rdst *rd_prev, *rd;
>
> rd_prev = NULL;
> - for (rd = &f->remote; rd; rd = rd->remote_next) {
> + for (rd = rdst; rd; rd = rd->remote_next) {
The remote destinations should be using one of our nice list macros.
And what about locking? or RCU?
next prev parent reply other threads:[~2013-05-29 22:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 10:00 [PATCH net-next v3 0/2] vxlan: allow specifying multiple default destinations Mike Rapoport
2013-05-29 10:00 ` [PATCH net-next v3 1/2] vxlan: introduce vxlan_rdst_append Mike Rapoport
2013-05-29 22:56 ` Stephen Hemminger [this message]
2013-05-30 8:42 ` Mike Rapoport
2013-05-29 10:00 ` [PATCH net-next v3 2/2] vxlan: allow specifying multiple default destinations Mike Rapoport
2013-05-30 11:09 ` Thomas Graf
2013-05-30 11:16 ` Mike Rapoport
2013-05-30 11:37 ` Thomas Graf
2013-05-31 16:17 ` Stephen Hemminger
2013-06-02 10:29 ` Mike Rapoport
2013-06-03 15:57 ` Stephen Hemminger
2013-06-03 19:47 ` Mike Rapoport
2013-06-03 18:26 ` [RFC] vxlan: convert remote list to list_rcu Stephen Hemminger
2013-06-03 20:18 ` David Stevens
2013-06-03 20:45 ` Stephen Hemminger
2013-06-03 21:46 ` David Stevens
2013-06-04 9:18 ` Mike Rapoport
2013-06-04 12:48 ` David Stevens
2013-06-04 17:20 ` Mike Rapoport
2013-06-04 19:02 ` David Stevens
2013-06-05 12:53 ` Mike Rapoport
2013-06-04 9:10 ` Mike Rapoport
2013-06-04 16:00 ` Stephen Hemminger
2013-06-04 16:29 ` David Stevens
2013-06-04 17:22 ` Mike Rapoport
2013-05-29 10:00 ` [PATCH iproute2] vxlan: allow specifying multiple default destinations Mike Rapoport
2013-05-29 10:13 ` Cong Wang
2013-05-29 10:52 ` Mike Rapoport
2013-05-29 22:56 ` Stephen Hemminger
2013-05-30 8:42 ` Mike Rapoport
2013-05-30 11:44 ` Thomas Graf
2013-05-30 12:46 ` Mike Rapoport
2013-05-30 15:57 ` Thomas Graf
2013-06-02 7:09 ` Mike Rapoport
2013-06-05 4:30 ` Stephen Hemminger
2013-06-05 12:58 ` Mike Rapoport
2013-05-30 17:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529155642.391b50b3@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=mike.rapoport@ravellosystems.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.