From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Subject: Re: [RFC] [PATCH 1/3] of: irq: rename of_irq_count to of_irq_valid_count
Date: Wed, 29 May 2013 23:25:30 +0100 [thread overview]
Message-ID: <20130529222530.453203E16F4@localhost> (raw)
In-Reply-To: <1369753729-12997-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
On Tue, 28 May 2013 17:08:47 +0200, Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> wrote:
> as we count valid mapped irq not just present irq
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Hmmm, even with it being in-accurately named, I think it is dangerous to
rename the existing function and re-use the old name. Anyone with
out-of-tree code will get the behaviour changed under their feet. I
think it would be better to drop this patch from the series.
g.
next prev parent reply other threads:[~2013-05-29 22:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 14:52 [RFC] [PATCH 0/3] of: allow to support irq domain register as platform_device for platform_device Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20130528145219.GA30411-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2013-05-28 15:08 ` [RFC] [PATCH 1/3] of: irq: rename of_irq_count to of_irq_valid_count Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1369753729-12997-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2013-05-28 15:08 ` [RFC] [PATCH 2/3] of: add of_irq_count: Count the number of IRQs a node present Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1369753729-12997-2-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2013-05-29 22:33 ` Grant Likely
2013-05-30 10:25 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-28 15:08 ` [RFC] [PATCH 3/3] IRQ: irq domain: defer of irq ressoure resolve at platform_drv_probe Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1369753729-12997-3-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2013-05-28 22:44 ` Rob Herring
[not found] ` <51A53363.6040004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-05-29 11:26 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-29 22:48 ` Grant Likely
2013-05-30 7:52 ` Arnd Bergmann
[not found] ` <201305300952.06036.arnd-r2nGTMty4D4@public.gmane.org>
2013-05-30 7:53 ` Grant Likely
2013-05-30 13:10 ` Arnd Bergmann
[not found] ` <201305301510.33650.arnd-r2nGTMty4D4@public.gmane.org>
2013-05-30 14:15 ` Grant Likely
[not found] ` <CACxGe6vewNv-4AtLeNDkzJnP50StrXtchi3GiKcd2HZG6YMvkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-30 14:57 ` Arnd Bergmann
2013-05-30 10:24 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-30 10:36 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20130530103639.GD19834-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2013-05-30 10:46 ` Grant Likely
2013-06-07 13:41 ` Alexander Sverdlin
2013-06-24 9:47 ` Alexander Sverdlin
2013-05-29 22:25 ` Grant Likely [this message]
2013-05-30 10:28 ` [RFC] [PATCH 1/3] of: irq: rename of_irq_count to of_irq_valid_count Jean-Christophe PLAGNIOL-VILLARD
2013-05-28 15:41 ` [RFC] [PATCH 0/3] of: allow to support irq domain register as platform_device for platform_device Arnd Bergmann
[not found] ` <201305281741.33951.arnd-r2nGTMty4D4@public.gmane.org>
2013-05-28 18:51 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529222530.453203E16F4@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
--cc=ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.