Re: [PATCH 1/6] t/send-email.sh: add test for suppress self

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, May 29, 2013 at 03:59:51PM -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> >> If we don't want to use \, this can also be done like this:
> >>
> >> FOO << EOF && 
> >> BLABLA
> >> EOF
> >>  BAR && 
> >>  VAR
> >>
> >> I think this is what you suggest.
> >
> > Yup, that is exactly what I meant (but no leading indentation before
> > BAR and VAR).
> >
> > That way, it is a lot more clear where the input is (the BLABLA is
> > fed to FOO and BAR and VAR do not have anything to do with it).
> >
> >>> > +		grep '^Cc:' msghdr1-$3 > actual-no-cc-$3 && \
> >>> > +		test_cmp expected-no-cc-$3 actual-no-cc-$3
> >
> > OK, so this is where the message begins, with the commit title "test
> > supress-cc.self...".
> 
> Another thing I forgot to say, if you are rerolling this patch
> anyway to follow that style, is that our newer tests typically
> write it like this:

What exactly should I notice here?

> test_supress_self () {
> 	test_commit $3 &&
>         test_when_finished "git reset --hard HEAD^" &&
>         write_script <<-EOF &&
>         sed -n -e s/^cccmd--//p \"\$1\"
> 	EOF
> 
> 	git commit --amend --author="$1 <$2>" -F - <<-EOF &&
> 	test suppress-cc.self $3 with name $1 email $2
> 
> 	$3
> 
> 	cccmd--"$1" <$2>
> 
>         Cc: "$1" <$2>
> 	Cc: $1 <$2>
> 	Signed-off-by: "$1" <$2>
> 	Signed-off-by: $1 <$2>
>         EOF
>         
>         clean_fake_sendmail &&
>         git format-patch --stdout -1 >"suppress-self-$3.patch" &&
>         git send-email --from="$1 <$2>" \
>         	--to=nobody@example.com \
>                 ... other args ...
>         ... verification steps for the send-email output ...
> }