From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Patch] Staging: winbond: Macros values enclosed in parenthesis
Date: Thu, 30 May 2013 11:45:37 +0000 [thread overview]
Message-ID: <20130530114537.GA18245@kroah.com> (raw)
In-Reply-To: <51A434EB.9070208@gmail.com>
On Tue, May 28, 2013 at 10:09:07AM +0530, Harsh Kumar wrote:
> Macros with complex values enclosed in parenthesis
What does that mean?
> -#define MTO_CNT_ANT(x) MTO_DATA().Cnt_Ant[(x)]
> -#define MTO_SQ_ANT(x) MTO_DATA().SQ_Ant[(x)]
> -#define MTO_AGING_TIMEOUT() MTO_DATA().aging_timeout
> +#define MTO_POWER_CHANGE_ENABLE() (MTO_DATA().PowerChangeEnable)
> +#define MTO_CCA_MODE() (MTO_DATA().CCA_Mode)
These are not "complex" values at all, this patch isn't needed,
checkpatch needs to be fixed to not complain about it.
thanks,
greg k-h
prev parent reply other threads:[~2013-05-30 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 4:51 [Patch] Staging: winbond: Macros values enclosed in parenthesis Harsh Kumar
2013-05-30 11:45 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530114537.GA18245@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.