All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Bohac <jbohac@suse.cz>,
	Steven Rostedt <rostedt@goodmis.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] nohz: Prevent broadcast source from stealing full dynticks timekeeping duty
Date: Thu, 30 May 2013 16:22:02 +0200	[thread overview]
Message-ID: <20130530142200.GA23384@somewhere> (raw)
In-Reply-To: <alpine.LFD.2.02.1305301554100.2905@ionos>

On Thu, May 30, 2013 at 03:57:17PM +0200, Thomas Gleixner wrote:
> On Wed, 29 May 2013, Frederic Weisbecker wrote:
> 
> > The timekeeping duty is currently assigned to the CPU that
> > handles the tick broadcast clock device by the time it is set in
> > one shot mode.
> > 
> > The reason for this is not entirely clear as outlined by Jiri
> > Bohac: https://patchwork.kernel.org/patch/2302951/
> > 
> > One could speculate though that it makes sure only one CPU
> > is woken up to fixup the timekeeping max deferment. But the
> > timekeeper can change anytime after the broadcast CPU becomes
> > idle. So probably we can remove this as in Jiri's patch, but
> > not late in the -rc's.
> 
> Looking at commit 7300711e (clockevents: broadcast fixup possible
> waiters) which introduced that takeover, I really can't see a reason
> why we must do that. It's safe to remove it completely even now.

Yeah it seems so, if you're ok I can commit https://patchwork.kernel.org/patch/2302951/
with your ack and send another pull request.

Thanks.

  reply	other threads:[~2013-05-30 14:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 16:39 [GIT PULL] nohz fixes Frederic Weisbecker
2013-05-29 16:39 ` [PATCH] nohz: Prevent broadcast source from stealing full dynticks timekeeping duty Frederic Weisbecker
2013-05-30 13:57   ` Thomas Gleixner
2013-05-30 14:22     ` Frederic Weisbecker [this message]
2013-05-30 14:39       ` Thomas Gleixner
2013-05-30 23:35         ` [PATCH] tick: Remove useless timekeeping duty attribution to broadcast source Frederic Weisbecker
2013-05-30 23:38 ` [GIT PULL] nohz fixes Frederic Weisbecker
2013-05-31 10:02   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130530142200.GA23384@somewhere \
    --to=fweisbec@gmail.com \
    --cc=bp@alien8.de \
    --cc=jbohac@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.