All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] dec.c - move to pci-bridge
Date: Thu, 30 May 2013 20:37:43 +0300	[thread overview]
Message-ID: <20130530173743.GB29091@redhat.com> (raw)
In-Reply-To: <51A76FF2.5090000@suse.de>

On Thu, May 30, 2013 at 05:27:46PM +0200, Andreas Färber wrote:
> Am 30.05.2013 11:30, schrieb Michael S. Tsirkin:
> > Looks like dec.c is in pci-host by mistake.
> > Moving it over to pci-bridge.
> > 
> > Cc: Andreas Färber <afaerber@suse.de>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  hw/pci-bridge/Makefile.objs |   2 +
> >  hw/pci-bridge/dec.c         | 156 ++++++++++++++++++++++++++++++++++++++++++++
> >  hw/pci-bridge/dec.h         |  10 +++
> >  hw/pci-host/Makefile.objs   |   1 -
> >  hw/pci-host/dec.c           | 156 --------------------------------------------
> >  hw/pci-host/dec.h           |  10 ---
> >  6 files changed, 168 insertions(+), 167 deletions(-)
> >  create mode 100644 hw/pci-bridge/dec.c
> >  create mode 100644 hw/pci-bridge/dec.h
> >  delete mode 100644 hw/pci-host/dec.c
> >  delete mode 100644 hw/pci-host/dec.h
> 
> Unfortunately you seem to have rename detection disabled - if this is
> just a move of the file with includes adjusted then
> 
> Acked-by: Andreas Färber <afaerber@suse.de>
> 
> Otherwise please supply a "readable" diff or point to a Git branch where
> we can check.
> 
> Thanks,
> Andreas

True. It will be readable in the pull request.

> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-05-30 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30  9:30 [Qemu-devel] [PATCH 0/2] fixup some fallback from tree reorg Michael S. Tsirkin
2013-05-30  9:30 ` [Qemu-devel] [PATCH 1/2] dec.c - move to pci-bridge Michael S. Tsirkin
2013-05-30 15:27   ` Andreas Färber
2013-05-30 17:37     ` Michael S. Tsirkin [this message]
2013-05-30  9:30 ` [Qemu-devel] [PATCH 2/2] firmware_abi: move to include/hw/nvram/ Michael S. Tsirkin
2013-05-30 15:29   ` Andreas Färber
2013-05-30 13:04 ` [Qemu-devel] [PATCH 0/2] fixup some fallback from tree reorg Paolo Bonzini
2013-05-30 13:07   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130530173743.GB29091@redhat.com \
    --to=mst@redhat.com \
    --cc=afaerber@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.