All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "Jesper Dangaard Brouer" <brouer@redhat.com>,
	"Stephen Hemminger" <stephen@networkplumber.org>,
	"David Miller" <davem@redhat.com>,
	j.vimal@gmail.com, "Michal Soltys" <soltys@ziu.info>,
	"Mike Frysinger" <vapier@gentoo.org>,
	"Jussi Kivilinna" <jussi.kivilinna@mbnet.fi>,
	"Patrick McHardy" <kaber@trash.net>,
	"Jiri Pirko" <jpirko@redhat.com>,
	"Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Dave Taht" <dave.taht@gmail.com>,
	netdev@vger.kernel.org, bloat@lists.bufferbloat.net,
	"Dan Siemon" <dan@coverfire.com>,
	"Jim Gettys" <jg@freedesktop.org>,
	"Steven Barth" <cyrus@openwrt.org>,
	"Felix Fietkau" <nbd@nbd.name>, "Jiri Benc" <jbenc@redhat.com>
Subject: Re: tc linklayer ADSL calc broken after commit 56b765b79 (htb: improved accuracy at high rates)
Date: Thu, 30 May 2013 17:55:59 +0200	[thread overview]
Message-ID: <20130530175559.7cbb6851@redhat.com> (raw)
In-Reply-To: <1369924750.5109.91.camel@edumazet-glaptop>

On Thu, 30 May 2013 07:39:10 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> On Thu, 2013-05-30 at 09:51 +0200, Jesper Dangaard Brouer wrote:
> > On Wed, 29 May 2013 08:52:04 -0700
> > Eric Dumazet <eric.dumazet@gmail.com> wrote:
> 
> > > I am not sure it will solve the ATM logic (with the 5 bytes
> > > overhead per 48 bytes cell)
> > 
> > Are you talking about, that for GSO frames we are not adding a encap
> > overhead to each "sub" skb.
> 
> This part is now done properly in qdisc_pkt_len_init() since linux-3.9

Thanks for the pointer, but qdisc_pkt_len_init() only adds the
EthMAC+IP+TCP header size for each GSO segment (stored in
qdisc_skb_cb(skb)->pkt_len).
It is still missing the AAL5 encapsulation overhead per GSO segment.

Besides I can see that __qdisc_calculate_pkt_len() "forgets" this
information and overwrites qdisc_skb_cb(skb)->pkt_len (iif a stab is
defined on the qdisc).

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer

  reply	other threads:[~2013-05-30 15:56 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 13:13 tc linklayer ADSL calc broken after commit 56b765b79 (htb: improved accuracy at high rates) Jesper Dangaard Brouer
2013-05-29 15:52 ` Eric Dumazet
2013-05-29 22:50   ` Stephen Hemminger
2013-05-29 23:18     ` Eric Dumazet
2013-05-30  9:15       ` Jesper Dangaard Brouer
2013-05-30  9:52         ` [Bloat] " Steinar H. Gunderson
     [not found]     ` <20130529155034.334092c5-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2013-05-30  0:34       ` Dave Taht
2013-05-30  8:09     ` Jesper Dangaard Brouer
2013-05-30  7:51   ` Jesper Dangaard Brouer
2013-05-30 14:39     ` Eric Dumazet
2013-05-30 15:55       ` Jesper Dangaard Brouer [this message]
2013-05-30 16:29         ` Jussi Kivilinna
2013-06-02 21:15 ` Eric Dumazet
2013-06-02 21:33   ` [PATCH iproute2] htb: report overhead attribute Eric Dumazet
2013-06-03 15:45     ` Rick Jones
2013-06-03 15:56       ` Eric Dumazet
2013-06-04 11:11         ` Jesper Dangaard Brouer
2013-06-04 13:58           ` Eric Dumazet
2013-06-04 15:08             ` Jesper Dangaard Brouer
2013-06-03 19:50       ` Jussi Kivilinna
2013-06-07 15:56     ` Stephen Hemminger
2013-06-07 16:00       ` Eric Dumazet
2013-06-04 12:13 ` Bad shaping at low rates, after commit 56b765b79 (htb: improved accuracy at high rates) Jesper Dangaard Brouer
2013-06-04 15:18   ` Eric Dumazet
2013-06-04 15:55     ` Eric Dumazet
2013-06-04 16:02       ` Eric Dumazet
2013-06-04 17:11         ` [PATCH] net_sched: htb: do not mix 1ns and 64ns time units Eric Dumazet
2013-06-04 20:21           ` Jesper Dangaard Brouer
     [not found]             ` <20130604222135.67eedab8-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-04 20:26               ` Dave Taht
2013-06-04 21:02                 ` Eric Dumazet
2013-06-04 20:50             ` Eric Dumazet
2013-06-05  0:44           ` David Miller
2013-06-06 13:55 ` RFC: Proposed fix for tc linklayer calc broken after commit 56b765b79 (htb: improved accuracy at high rates) Jesper Dangaard Brouer
2013-06-06 14:28   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130530175559.7cbb6851@redhat.com \
    --to=jbrouer@redhat.com \
    --cc=bloat@lists.bufferbloat.net \
    --cc=brouer@redhat.com \
    --cc=cyrus@openwrt.org \
    --cc=dan@coverfire.com \
    --cc=dave.taht@gmail.com \
    --cc=davem@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=j.vimal@gmail.com \
    --cc=jbenc@redhat.com \
    --cc=jg@freedesktop.org \
    --cc=jpirko@redhat.com \
    --cc=jussi.kivilinna@mbnet.fi \
    --cc=kaber@trash.net \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=soltys@ziu.info \
    --cc=stephen@networkplumber.org \
    --cc=toke@toke.dk \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.