From: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
djbw-b10kYP2dOMg@public.gmane.org
Subject: Re: [PATCH 2/2] dma: tegra: avoid channel lock up after free
Date: Thu, 30 May 2013 23:37:10 +0530 [thread overview]
Message-ID: <20130530180710.GI3767@intel.com> (raw)
In-Reply-To: <519112D4.7010004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Mon, May 13, 2013 at 10:20:36AM -0600, Stephen Warren wrote:
> On 05/11/2013 10:30 AM, Dmitry Osipenko wrote:
> > Lock scenario: Channel 1 was allocated and prepared as slave_sg, used and freed.
> > Now preparation of cyclic dma on channel 1 will fail with err "DMA configuration
> > conflict" because tdc->isr_handler still setted to handle_once_dma_done.
> >
> > This happens because tegra_dma_abort_all() won't be called on channel freeing
> > if pending list is empty and channel not busy. We need to clear isr_handler
> > on channel freeing to avoid locking.
> ...
> > Reposting with dma maintainers cc'd as suggested by Stephen.
> > Added Stephen's ack.
Applied, both thanks
>
> Just for reference (not need to repost again): You'd usually send the
> messages *to* the DMA maintainers since they will be taking the patches
> through their tree, and then Ccing anyone else.
get_maintainer.pl is your friend for this
--
~Vinod
next prev parent reply other threads:[~2013-05-30 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 16:30 [PATCH 1/2] dma: tegra20-apbdma: err message correction Dmitry Osipenko
[not found] ` <1368289853-20011-1-git-send-email-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-05-11 16:30 ` [PATCH 2/2] dma: tegra: avoid channel lock up after free Dmitry Osipenko
[not found] ` <1368289853-20011-2-git-send-email-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-05-13 16:20 ` Stephen Warren
[not found] ` <519112D4.7010004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-13 21:11 ` Dmitry Osipenko
2013-05-30 18:07 ` Vinod Koul [this message]
2013-05-13 4:00 ` [PATCH 1/2] dma: tegra20-apbdma: err message correction Laxman Dewangan
2013-05-13 4:04 ` Laxman Dewangan
[not found] ` <51906635.3040507-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-30 18:05 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2013-05-10 21:06 Dmitry Osipenko
[not found] ` <1368220014-12036-1-git-send-email-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-05-10 21:06 ` [PATCH 2/2] dma: tegra: avoid channel lock up after free Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530180710.GI3767@intel.com \
--to=vinod.koul-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=djbw-b10kYP2dOMg@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.