From: Marek Vasut <marex@denx.de>
To: alsa-devel@alsa-project.org
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: sgtl5000: Do not read registers prior to turning on the supplies
Date: Fri, 31 May 2013 00:36:11 +0200 [thread overview]
Message-ID: <201305310036.11681.marex@denx.de> (raw)
In-Reply-To: <20130528143255.GK3660@sirena.org.uk>
Hi Mark, Fabio,
> On Tue, May 28, 2013 at 11:04:18AM -0300, Fabio Estevam wrote:
> > Commit b871f1ad (ASoC: sgtl5000: Read SGTL5000_CHIP_ID in i2c_probe())
> > placed the code for reading the codec revision prior to turning on the
> > power supplies.
> >
> > Even though this works on some systems that always have the codec power
> > supplies enabled, this is not correct, so revert this commit.
>
> It seems like a better fix for this is to just enable the supplies while
> doing the device identification?
This patch does kinda fix it for me, but the system takes quite some time to
init the soundcard now (a few seconds). After reverting these two patches, the
soundcard works just fine (like before):
ASoC: sgtl5000: Fix driver probe after reset
ASoC: sgtl5000: Read SGTL5000_CHIP_ID in i2c_probe()
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-05-30 22:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 14:04 [PATCH] ASoC: sgtl5000: Do not read registers prior to turning on the supplies Fabio Estevam
2013-05-28 14:32 ` Mark Brown
2013-05-30 22:36 ` Marek Vasut [this message]
2013-05-31 5:09 ` Estevam Fabio-R49496
2013-05-31 15:32 ` Marek Vasut
2013-05-31 15:36 ` Fabio Estevam
2013-05-31 15:45 ` Marek Vasut
2013-05-31 15:52 ` Fabio Estevam
2013-05-31 17:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305310036.11681.marex@denx.de \
--to=marex@denx.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.