From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiQ7E-0003X7-6J for qemu-devel@nongnu.org; Fri, 31 May 2013 10:15:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiQ7C-0004LW-AG for qemu-devel@nongnu.org; Fri, 31 May 2013 10:15:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiQ7C-0004LR-1M for qemu-devel@nongnu.org; Fri, 31 May 2013 10:15:34 -0400 Date: Fri, 31 May 2013 10:15:26 -0400 From: Luiz Capitulino Message-ID: <20130531101526.26c8f35d@redhat.com> In-Reply-To: <1369926481-20720-1-git-send-email-afaerber@suse.de> References: <1369926481-20720-1-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu v3 0/9] dump: Build cleanups redone List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: qemu-devel@nongnu.org, Vincent Rabin , qiaonuohan@cn.fujitsu.com, pbonzini@redhat.com, Jens Freimann On Thu, 30 May 2013 17:07:52 +0200 Andreas F=C3=A4rber wrote: > Hello, >=20 > This series is an alternative to patches previously queued or posted, > based on virgin master. >=20 > As requested by Paolo, this replaces Kate's previous memory_mapping split > and my follow-ups and instead goes directly for moving things to CPUState. >=20 > All knowledge about dump / memory mapping are moved away from configure. >=20 > v3 adds an additional patch proposing a semantic change to facilitate CPU > handling and it prepends another bugfix to avoid merge conflicts. I had some minor comments, but series looks good to me. Also, Andreas, I'm going to cherry-pick mine and Qiao's fixes into QMP tree so that they're included in my today's pull request. >=20 > Regards, > Andreas >=20 > v2 -> v3: > * Incorporate Luiz' x86 bugfix. > * Append a patch to resolve the open-coded CPU loops. > * Massage CONFIG_HAVE_* commit messages (they were previously reordered). >=20 > v1 -> v2: > * Dropped Kate's memory_mapping split > * Dropped target_ulong cleanup and replaced with typedef > * Amended CPUArchState cleanups with introducing hooks in CPUClass > * Drop memory_memory stubs instead of moving them >=20 > Cc: Wen Congyang > Cc: Qiao Nuohan > Cc: Jens Freimann > Cc: Vincent Rabin > Cc: Paolo Bonzini > Cc: Luiz Capitulino >=20 > Andreas F=C3=A4rber (7): > dump: Move stubs into libqemustub.a > cpu: Turn cpu_paging_enabled() into a CPUState hook > memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h > cpu: Turn cpu_get_memory_mapping() into a CPUState hook > memory_mapping: Drop qemu_get_memory_mapping() stub > dump: Unconditionally compile > memory_mapping: Change qemu_get_guest_memory_mapping() semantics >=20 > Luiz Capitulino (1): > target-i386: walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE > addresses >=20 > Qiao Nuohan (1): > target-i386: Fix mask of pte index in memory mapping >=20 > Makefile.target | 8 ++------ > configure | 8 -------- > hmp-commands.hx | 2 -- > include/qemu/typedefs.h | 2 ++ > include/qom/cpu.h | 21 ++++++++++++++++++++ > include/sysemu/memory_mapping.h | 8 +++----- > memory_mapping-stub.c | 33 ------------------------------ > memory_mapping.c | 42 +++++++++++++++++++++------------= ------ > qom/cpu.c | 27 +++++++++++++++++++++++++ > stubs/Makefile.objs | 1 + > dump-stub.c =3D> stubs/dump.c | 8 -------- > target-i386/arch_memory_mapping.c | 23 +++++++++++---------- > target-i386/cpu-qom.h | 2 ++ > target-i386/cpu.c | 12 +++++++++-- > 14 files changed, 103 insertions(+), 94 deletions(-) > delete mode 100644 memory_mapping-stub.c > rename dump-stub.c =3D> stubs/dump.c (65%) >=20