From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Patch 2/2] Staging: winbond: Memory & urb freed
Date: Fri, 31 May 2013 15:57:04 +0000 [thread overview]
Message-ID: <20130531155704.GA28112@mwanda> (raw)
In-Reply-To: <51A8C27B.9090003@gmail.com>
On Fri, May 31, 2013 at 09:02:11PM +0530, Harsh Kumar wrote:
> Memory & urb should be freed before exiting from the function, I think.
>
They are freed in Wb35Reg_EP0VM_complete() so this patch will make
the system crash right away. Btw, there are tons of real bugs that
I know about but which I don't fix because I don't know what the
right thing to do is.
> Note: This patch is to be applied after applying the earlier patch i.e [patch 1/2]
>
In a patch series it's assumed that we have to apply them in order,
but if you need to add a comment like this the right place to do it
is under the --- line and before the patch.
> Signed-off-by: Harsh Kumar <harsh1kumar@gmail.com>
>
> ---
Side comments not intended for the perment git log go here.
> drivers/staging/winbond/wb35reg.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
regards,
dan carpenter
next prev parent reply other threads:[~2013-05-31 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 15:44 [Patch 2/2] Staging: winbond: Memory & urb freed Harsh Kumar
2013-05-31 15:57 ` Dan Carpenter [this message]
2013-05-31 16:30 ` Harsh Kumar
2013-05-31 16:39 ` Dan Carpenter
2013-05-31 16:46 ` Julia Lawall
2013-05-31 17:12 ` Harsh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531155704.GA28112@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.