From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH V2 3/6] ARM: tegra: make tegra_resume can work for Tegra114
Date: Sat, 1 Jun 2013 11:47:30 +0200 [thread overview]
Message-ID: <201306011147.30379.arnd@arndb.de> (raw)
In-Reply-To: <51A9364B.4090002-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Saturday 01 June 2013, Stephen Warren wrote:
> On 05/31/2013 04:41 PM, Arnd Bergmann wrote:
> > On Monday 20 May 2013, Joseph Lo wrote:
> >> + cpu_to_csr_req r1, r0
> >> + mov32 r2, TEGRA_FLOW_CTRL_BASE
> >> + ldr r1, [r2, r1]
> >
> > This causes build errors now, since cpu_to_csr_req is not defined anywhere.
>
> What build error are you seeing? I built next-20130531 earlier today
> without any issue.
>
> I do remember making a similar comment during review of this patch that
> cpu_to_csr_req wasn't defined anywhere, but IIRC Joseph pointed me to
> another patch in the series which had added it, or something like that.
Sorry, I should have mentioned it was using randconfig, all the defconfig
builds work fine. The code is inside of "#ifndef CONFIG_ARCH_TEGRA_2x_SOC",
but Tegra2 is normally enabled in defconfig, so it does not get built.
I suspect the #ifdef is wrong as well, and should have been "if tegra3
or tegra4" instead. Joseph, can you clarify the intent of this?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/6] ARM: tegra: make tegra_resume can work for Tegra114
Date: Sat, 1 Jun 2013 11:47:30 +0200 [thread overview]
Message-ID: <201306011147.30379.arnd@arndb.de> (raw)
In-Reply-To: <51A9364B.4090002@wwwdotorg.org>
On Saturday 01 June 2013, Stephen Warren wrote:
> On 05/31/2013 04:41 PM, Arnd Bergmann wrote:
> > On Monday 20 May 2013, Joseph Lo wrote:
> >> + cpu_to_csr_req r1, r0
> >> + mov32 r2, TEGRA_FLOW_CTRL_BASE
> >> + ldr r1, [r2, r1]
> >
> > This causes build errors now, since cpu_to_csr_req is not defined anywhere.
>
> What build error are you seeing? I built next-20130531 earlier today
> without any issue.
>
> I do remember making a similar comment during review of this patch that
> cpu_to_csr_req wasn't defined anywhere, but IIRC Joseph pointed me to
> another patch in the series which had added it, or something like that.
Sorry, I should have mentioned it was using randconfig, all the defconfig
builds work fine. The code is inside of "#ifndef CONFIG_ARCH_TEGRA_2x_SOC",
but Tegra2 is normally enabled in defconfig, so it does not get built.
I suspect the #ifdef is wrong as well, and should have been "if tegra3
or tegra4" instead. Joseph, can you clarify the intent of this?
Arnd
next prev parent reply other threads:[~2013-06-01 9:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 10:39 [PATCH V2 0/6] ARM: tegra114: add CPU hotplug support Joseph Lo
2013-05-20 10:39 ` Joseph Lo
[not found] ` <1369046369-12489-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-20 10:39 ` [PATCH V2 1/6] ARM: tegra: add an assembly marco to check Tegra SoC ID Joseph Lo
2013-05-20 10:39 ` Joseph Lo
2013-05-20 10:39 ` [PATCH V2 2/6] ARM: tegra: skip SCU and PL310 code when CPU is not Cortex-A9 Joseph Lo
2013-05-20 10:39 ` Joseph Lo
2013-05-20 10:39 ` [PATCH V2 3/6] ARM: tegra: make tegra_resume can work for Tegra114 Joseph Lo
2013-05-20 10:39 ` Joseph Lo
[not found] ` <1369046369-12489-4-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-31 22:41 ` Arnd Bergmann
2013-05-31 22:41 ` Arnd Bergmann
[not found] ` <201306010041.07230.arnd-r2nGTMty4D4@public.gmane.org>
2013-05-31 23:46 ` Stephen Warren
2013-05-31 23:46 ` Stephen Warren
[not found] ` <51A9364B.4090002-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-01 9:47 ` Arnd Bergmann [this message]
2013-06-01 9:47 ` Arnd Bergmann
[not found] ` <201306011147.30379.arnd-r2nGTMty4D4@public.gmane.org>
2013-06-03 2:16 ` Joseph Lo
2013-06-03 2:16 ` Joseph Lo
2013-05-20 10:39 ` [PATCH V2 4/6] ARM: tegra114: add power up sequence for warm boot CPU Joseph Lo
2013-05-20 10:39 ` Joseph Lo
2013-05-20 10:39 ` [PATCH V2 5/6] clk: tegra114: implement wait_for_reset and disable_clock for tegra_cpu_car_ops Joseph Lo
2013-05-20 10:39 ` Joseph Lo
2013-05-20 10:39 ` [PATCH V2 6/6] ARM: tegra114: add CPU hotplug support Joseph Lo
2013-05-20 10:39 ` Joseph Lo
2013-05-20 23:20 ` [PATCH V2 0/6] " Stephen Warren
2013-05-20 23:20 ` Stephen Warren
[not found] ` <519AAFCB.8060007-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-21 9:58 ` Joseph Lo
2013-05-21 9:58 ` Joseph Lo
2013-05-22 21:21 ` Stephen Warren
2013-05-22 21:21 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306011147.30379.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.