From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V2 3/6] ARM: tegra: make tegra_resume can work for Tegra114 Date: Sat, 1 Jun 2013 11:47:30 +0200 Message-ID: <201306011147.30379.arnd@arndb.de> References: <1369046369-12489-1-git-send-email-josephl@nvidia.com> <201306010041.07230.arnd@arndb.de> <51A9364B.4090002@wwwdotorg.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51A9364B.4090002-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Stephen Warren , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joseph Lo List-Id: linux-tegra@vger.kernel.org On Saturday 01 June 2013, Stephen Warren wrote: > On 05/31/2013 04:41 PM, Arnd Bergmann wrote: > > On Monday 20 May 2013, Joseph Lo wrote: > >> + cpu_to_csr_req r1, r0 > >> + mov32 r2, TEGRA_FLOW_CTRL_BASE > >> + ldr r1, [r2, r1] > > > > This causes build errors now, since cpu_to_csr_req is not defined anywhere. > > What build error are you seeing? I built next-20130531 earlier today > without any issue. > > I do remember making a similar comment during review of this patch that > cpu_to_csr_req wasn't defined anywhere, but IIRC Joseph pointed me to > another patch in the series which had added it, or something like that. Sorry, I should have mentioned it was using randconfig, all the defconfig builds work fine. The code is inside of "#ifndef CONFIG_ARCH_TEGRA_2x_SOC", but Tegra2 is normally enabled in defconfig, so it does not get built. I suspect the #ifdef is wrong as well, and should have been "if tegra3 or tegra4" instead. Joseph, can you clarify the intent of this? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Sat, 1 Jun 2013 11:47:30 +0200 Subject: [PATCH V2 3/6] ARM: tegra: make tegra_resume can work for Tegra114 In-Reply-To: <51A9364B.4090002@wwwdotorg.org> References: <1369046369-12489-1-git-send-email-josephl@nvidia.com> <201306010041.07230.arnd@arndb.de> <51A9364B.4090002@wwwdotorg.org> Message-ID: <201306011147.30379.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday 01 June 2013, Stephen Warren wrote: > On 05/31/2013 04:41 PM, Arnd Bergmann wrote: > > On Monday 20 May 2013, Joseph Lo wrote: > >> + cpu_to_csr_req r1, r0 > >> + mov32 r2, TEGRA_FLOW_CTRL_BASE > >> + ldr r1, [r2, r1] > > > > This causes build errors now, since cpu_to_csr_req is not defined anywhere. > > What build error are you seeing? I built next-20130531 earlier today > without any issue. > > I do remember making a similar comment during review of this patch that > cpu_to_csr_req wasn't defined anywhere, but IIRC Joseph pointed me to > another patch in the series which had added it, or something like that. Sorry, I should have mentioned it was using randconfig, all the defconfig builds work fine. The code is inside of "#ifndef CONFIG_ARCH_TEGRA_2x_SOC", but Tegra2 is normally enabled in defconfig, so it does not get built. I suspect the #ifdef is wrong as well, and should have been "if tegra3 or tegra4" instead. Joseph, can you clarify the intent of this? Arnd