Re: [PATCH v3 02/13] acpi: Print Hot-Pluggable Field in SRAT.

[Wanpeng Li <liwanp@linux.vnet.ibm.com>]

On Fri, May 24, 2013 at 05:29:11PM +0800, Tang Chen wrote:
>The Hot-Pluggable field in SRAT suggests if the memory could be
>hotplugged while the system is running. Print it as well when
>parsing SRAT will help users to know which memory is hotpluggable.
>

Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

>Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
>---
> arch/x86/mm/srat.c |    9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/arch/x86/mm/srat.c b/arch/x86/mm/srat.c
>index 443f9ef..5055fa7 100644
>--- a/arch/x86/mm/srat.c
>+++ b/arch/x86/mm/srat.c
>@@ -146,6 +146,7 @@ int __init
> acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma)
> {
> 	u64 start, end;
>+	u32 hotpluggable;
> 	int node, pxm;
>
> 	if (srat_disabled())
>@@ -154,7 +155,8 @@ acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma)
> 		goto out_err_bad_srat;
> 	if ((ma->flags & ACPI_SRAT_MEM_ENABLED) == 0)
> 		goto out_err;
>-	if ((ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) && !save_add_info())
>+	hotpluggable = ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE;
>+	if (hotpluggable && !save_add_info())
> 		goto out_err;
>
> 	start = ma->base_address;
>@@ -174,9 +176,10 @@ acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma)
>
> 	node_set(node, numa_nodes_parsed);
>
>-	printk(KERN_INFO "SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]\n",
>+	printk(KERN_INFO "SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx] %s\n",
> 	       node, pxm,
>-	       (unsigned long long) start, (unsigned long long) end - 1);
>+	       (unsigned long long) start, (unsigned long long) end - 1,
>+	       hotpluggable ? "Hot Pluggable" : "");
>
> 	return 0;
> out_err_bad_srat:
>-- 
>1.7.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>