All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kyle McMartin <kyle@infradead.org>
Cc: linux-kernel@vger.kernel.org, karthik.manamcheri@gmail.com,
	torvalds@linuxfoundation.org
Subject: Re: Revert "serial: 8250: Make SERIAL_8250_RUNTIME_UARTS work correctly"
Date: Mon, 3 Jun 2013 09:55:31 -0700	[thread overview]
Message-ID: <20130603165531.GA20412@kroah.com> (raw)
In-Reply-To: <20130603133826.GE8270@merlin.infradead.org>

On Mon, Jun 03, 2013 at 09:38:26AM -0400, Kyle McMartin wrote:
> This reverts commit cfcec52e9781f08948c6eb98198d65c45be75a70.
> 
> This regresses a longstanding behaviour on X86 systems, which end up with
> PCI serial ports moving between ttyS4 and ttyS0 when you bisect to opposite
> sides of this commit, resulting in the need to constantly modify the console
> setting in order to bisect across it.
> 
> Please revert, we can work on solving this for ARM platforms in a less
> disruptive way.

Ugh, how did this break x86 systems?  Karthik, you said this wouldn't
affect anyone else, what did you test it on?

> Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>

I'll go queue this up for the next -rc release, thanks Kyle.

greg k-h

  reply	other threads:[~2013-06-03 16:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 13:38 Revert "serial: 8250: Make SERIAL_8250_RUNTIME_UARTS work correctly" Kyle McMartin
2013-06-03 16:55 ` Greg KH [this message]
2013-06-03 17:03   ` Kyle McMartin
2013-06-03 17:09     ` Greg KH
     [not found]     ` <CAES2cWxYsxgjWzgNuhrWDoC7t2XrZQdeTe47ftWaCdg-2QoHUg@mail.gmail.com>
2013-06-03 20:32       ` Greg KH
     [not found]         ` <CAES2cWwPSpsqYdBHH51gVsCFdh_YVnADwzU+SKXqgzQwZMUVEA@mail.gmail.com>
2013-06-03 21:37           ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2013-06-03 20:05 Karthik Manamcheri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130603165531.GA20412@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=karthik.manamcheri@gmail.com \
    --cc=kyle@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.