All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Chan <benchan@chromium.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Sage Ahn <syahn@gctsemi.com>
Subject: Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC
Date: Mon, 3 Jun 2013 10:48:47 -0700	[thread overview]
Message-ID: <20130603174847.GA11111@kroah.com> (raw)
In-Reply-To: <1370280225-27479-1-git-send-email-benchan@chromium.org>

On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
> The gdm72xx driver needs to have either the USB or SDIO implementation
> enabled to provide useful functionalities, so the driver should depend
> on either USB or MMC.
> 
> Signed-off-by: Ben Chan <benchan@chromium.org>
> Cc: Sage Ahn <syahn@gctsemi.com>
> ---
>  drivers/staging/gdm72xx/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
> index 6905913..8af0dd4 100644
> --- a/drivers/staging/gdm72xx/Kconfig
> +++ b/drivers/staging/gdm72xx/Kconfig
> @@ -4,7 +4,7 @@
>  
>  menuconfig WIMAX_GDM72XX
>  	tristate "GCT GDM72xx WiMAX support"
> -	depends on NET
> +	depends on NET && (USB || MMC)

Alan Stern already told you how this would not solve the problem, why
did you resend it to me again?

And you forgot the "Reported-by:" line above, giving proper credit to
the person who told you about this problem.

Please fix both of them and resend.

thanks,

greg k-h

  reply	other threads:[~2013-06-03 17:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 17:23 [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC Ben Chan
2013-06-03 17:48 ` Greg Kroah-Hartman [this message]
2013-06-03 18:18   ` Ben Chan
2013-06-03 18:38     ` Ben Chan
2013-06-03 18:30 ` Greg Kroah-Hartman
2013-06-03 19:08   ` Greg Kroah-Hartman
2013-06-04  4:52     ` Ben Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130603174847.GA11111@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=benchan@chromium.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syahn@gctsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.