All of lore.kernel.org
 help / color / mirror / Atom feed
From: w@1wt.eu (Willy Tarreau)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: atags: add support for Marvell's u-boot
Date: Mon, 3 Jun 2013 20:30:57 +0200	[thread overview]
Message-ID: <20130603183057.GA9868@1wt.eu> (raw)
In-Reply-To: <20130603181437.GO3803@titan.lakedaemon.net>

Hi Jason,

On Mon, Jun 03, 2013 at 02:14:37PM -0400, Jason Cooper wrote:
> > I understand your points, but then what could we do to get our devices
> > to have properly working ethernet interfaces ? These devices have already
> > been sold, and from what I've seen they've been using this ID since at
> > least the Kirkwood devices.
> > 
> > I found no other way to get the MAC address once the system is booted.
> > I would have no problem having some board-spec code locate the atags
> > and set the MAC, but it looks like the information is lost very early
> > and is not available anymore soon after the boot (or at least I couldn't
> > find it anywhere else).
> > 
> > It's really not with happiness that I had to add this part to the ATAGs,
> > but because I didn't find another solution :-(
> 
> Please take a look at Sebastian's approach, it's currently a wip:
> 
>   ARM: kirkwood: proper retain MAC address workaround on DT ethernet
> 
> The discussion following that patch should give you some good ideas.

I remember this discussion, but it is different and does not apply here.
Sebastian fixed an issue with a properly configured NIC which used to
lose its MAC, so the solution consisted in saving it early in the DT.

In the mv_neta case, the NICs are not configured yet and we need to
find the MAC somewhere. I only found it in the ATAGs and nowhere else.
Well, in fact u-boot sets it on the MAC used to boot from the network
if such a boot is performed, but that's all. So in practice you boot
without the MAC address anywhere but in the ATAGs. I'd be happy to
find a way to parse non-standard atags in a board-specific file but
they're lost early it seems :-(

Thanks,
Willy

  parent reply	other threads:[~2013-06-03 18:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 16:45 [PATCH] ARM: atags: add support for Marvell's u-boot Thomas Petazzoni
2013-06-03 16:57 ` Jason Cooper
2013-06-03 17:09   ` Thomas Petazzoni
2013-06-03 17:42     ` Jason Cooper
2013-06-03 17:10 ` Russell King - ARM Linux
2013-06-03 17:56   ` Willy Tarreau
2013-06-03 18:14     ` Jason Cooper
2013-06-03 18:26       ` Jason Cooper
2013-06-03 18:30       ` Willy Tarreau [this message]
2013-06-03 18:41         ` Jason Cooper
2013-06-03 19:07           ` Nicolas Pitre
2013-06-03 19:17             ` Jason Cooper
2013-06-03 19:46               ` Nicolas Pitre
2013-06-03 21:07               ` Willy Tarreau
2013-06-04  8:13               ` Thomas Petazzoni
2013-06-04  8:48                 ` Sebastian Hesselbarth
2013-06-04 10:50                   ` Jason Cooper
2013-06-04  8:10             ` Thomas Petazzoni
2013-06-04  8:43               ` Sebastian Hesselbarth
2013-06-03 19:01         ` Nicolas Pitre
2013-06-03 21:04           ` Willy Tarreau
2013-06-04  8:05         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130603183057.GA9868@1wt.eu \
    --to=w@1wt.eu \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.