From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource: armada-xp: always register local_timer_ops
Date: Mon, 3 Jun 2013 18:04:05 -0700 [thread overview]
Message-ID: <20130604010405.GJ599@codeaurora.org> (raw)
In-Reply-To: <3039627.dHjlxm4JCV@wuerfel>
On 06/04, Arnd Bergmann wrote:
> The call to local_timer_register is hidden behind an #ifdef, which
> turns the armada_370_xp_local_timer_ops into a potentially unused
> variable, causing this warning:
>
> time-armada-370-xp.c:208:31: warning: 'armada_370_xp_local_timer_ops' defined but not used [-Wunused-variable]
> static struct local_timer_ops armada_370_xp_local_timer_ops __cpuinitdata = {
> ^
>
> Since local_timer_register() itself doesn't do anything, just removing
> the #ifdef makes the code look nicer and gets rid of the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Cc: Jason Cooper <jason@lakedaemon.net>
> ---
>
> Please apply for 3.11
>
This will conflict slightly with my series[1]. If this is targeted
for 3.11 it may be better to just drop this patch and let my
series remove the ops structure entirely.
[1] https://lkml.org/lkml/2013/6/3/583
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
prev parent reply other threads:[~2013-06-04 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 22:03 [PATCH] clocksource: armada-xp: always register local_timer_ops Arnd Bergmann
2013-06-03 22:11 ` Jason Cooper
2013-06-04 1:04 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604010405.GJ599@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.