All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gong <gong.chen@linux.intel.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-acpi@vger.kernel.org, rjw@sisk.pl, lenb@kernel.org,
	Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()
Date: Mon, 3 Jun 2013 23:18:28 -0400	[thread overview]
Message-ID: <20130604031828.GA20448@gchen.bj.intel.com> (raw)
In-Reply-To: <1369827977-29975-1-git-send-email-sachin.kamat@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

On Wed, May 29, 2013 at 05:16:17PM +0530, Sachin Kamat wrote:
> Date:	Wed, 29 May 2013 17:16:17 +0530
> From: Sachin Kamat <sachin.kamat@linaro.org>
> To: linux-acpi@vger.kernel.org
> Cc: rjw@sisk.pl, lenb@kernel.org, sachin.kamat@linaro.org, Huang Ying
>  <ying.huang@intel.com>
> Subject: [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata()
> X-Mailer: git-send-email 1.7.9.5
> 
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
> 
Your description doesn't give any meaningful explanation.

> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Huang Ying <ying.huang@intel.com>
> ---
>  drivers/acpi/apei/ghes.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d668a8a..e03c20e 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1011,8 +1011,6 @@ static int ghes_remove(struct platform_device *ghes_dev)
>  
>  	kfree(ghes);
>  
> -	platform_set_drvdata(ghes_dev, NULL);
> -
>  	return 0;
>  }
>  
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-06-04  3:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 11:46 [PATCH 1/1] ACPI: ghes: Remove redundant platform_set_drvdata() Sachin Kamat
2013-06-04  3:18 ` Chen Gong [this message]
2013-06-04  3:34   ` Sachin Kamat
2013-06-04 11:10     ` Rafael J. Wysocki
2013-06-04 11:29       ` Sachin Kamat
2013-06-28  8:44       ` Sachin Kamat
2013-06-28 10:44         ` Rafael J. Wysocki
2013-06-28 18:47           ` Tony Luck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130604031828.GA20448@gchen.bj.intel.com \
    --to=gong.chen@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=sachin.kamat@linaro.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.