From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [BUG] acess_ok() missing from zerocopy_sg_from_iovec()
Date: Tue, 4 Jun 2013 08:30:04 +0300 [thread overview]
Message-ID: <20130604053004.GA19433@redhat.com> (raw)
In-Reply-To: <1370306052.24311.193.camel@edumazet-glaptop>
On Mon, Jun 03, 2013 at 05:34:12PM -0700, Eric Dumazet wrote:
> It looks like access_ok(VERIFY_READ, base, len) checks are missing in
> drivers/net/tun.c & drivers/net/macvtap.c before the
> get_user_pages_fast() calls.
>
> Or am I missing something ?
These paths (zero-copy xmit) are only used through vhost-net which does
its own access_ok checks.
Needs a comment, I agree.
prev parent reply other threads:[~2013-06-04 5:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 0:34 [BUG] acess_ok() missing from zerocopy_sg_from_iovec() Eric Dumazet
2013-06-04 1:06 ` Eric Dumazet
2013-06-04 3:25 ` Jason Wang
2013-06-04 5:32 ` Michael S. Tsirkin
2013-06-04 5:30 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604053004.GA19433@redhat.com \
--to=mst@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.