From: Lee Jones <lee.jones@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Samuel Ortiz'" <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
"'Linus Walleij'" <linus.walleij@linaro.org>,
"'Srinidhi Kasagar'" <srinidhi.kasagar@stericsson.com>,
"'Andy Shevchenko'" <andy.shevchenko@gmail.com>
Subject: Re: [PATCH V3] mfd: replace strict_strtoul() with kstrtoul()
Date: Tue, 4 Jun 2013 08:23:14 +0100 [thread overview]
Message-ID: <20130604072314.GJ3370@gmail.com> (raw)
In-Reply-To: <001101ce60d9$a39936a0$eacba3e0$@samsung.com>
On Tue, 04 Jun 2013, Jingoo Han wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> Changes since v1:
> - Removed redundant variables 'u8 reg'.
> - Changed the type of 'user_value' from 'unsigned long' to 'u8'.
> - Replaced kstrtoul() with kstrtou8() to handle u8 variable.
> - Added Andy Shevchenko's Reviewed-by.
>
> Changes since v1:
> - Used return code from kstrtoul().
> - Changed the type of 'user_reg' from 'unsigned long' to 'u8'.
> - Replaced kstrtoul() with kstrtou8() to handle u8 variable.
>
> drivers/mfd/aat2870-core.c | 5 +++--
> drivers/mfd/ab3100-core.c | 28 ++++++++++------------------
> drivers/mfd/ab8500-debugfs.c | 2 +-
> 3 files changed, 14 insertions(+), 21 deletions(-)
Applied.
If Andy has any further comments, I'll replace the applied version
with any v3 patch which you send.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-06-04 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 4:11 [PATCH V3] mfd: replace strict_strtoul() with kstrtoul() Jingoo Han
2013-06-04 7:23 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604072314.GJ3370@gmail.com \
--to=lee.jones@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=srinidhi.kasagar@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.