From: Lee Jones <lee.jones@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
David Brown <davidb@codeaurora.org>
Subject: Re: [PATCHv2 2/2] mfd: ssbi: Use devm_* and simplify code
Date: Tue, 4 Jun 2013 08:33:35 +0100 [thread overview]
Message-ID: <20130604073335.GK3370@gmail.com> (raw)
In-Reply-To: <1370288384-3122-2-git-send-email-sboyd@codeaurora.org>
On Mon, 03 Jun 2013, Stephen Boyd wrote:
> Use devm_ioremap_resource and devm_kzalloc to simplify error
> paths and reduce lines of code. Also use dev_err() to keep
> consistency and drop the .remove function because the devm
> functions take care of what it's doing besides the now obsolete
> platform_set_drvdata() which we can just drop. Finally, use
> module_platform_driver() to save some more lines.
>
> Cc: David Brown <davidb@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Really nice.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-06-04 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 19:39 [PATCHv2 1/2] mfd: ssbi: Add MODULE_DEVICE_TABLE Stephen Boyd
2013-06-03 19:39 ` [PATCHv2 2/2] mfd: ssbi: Use devm_* and simplify code Stephen Boyd
2013-06-04 7:33 ` Lee Jones [this message]
2013-06-17 23:51 ` [PATCHv2 1/2] mfd: ssbi: Add MODULE_DEVICE_TABLE Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604073335.GK3370@gmail.com \
--to=lee.jones@linaro.org \
--cc=davidb@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.