From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 4 Jun 2013 08:35:07 +0100 Subject: [PATCH] ARM: ux500: register LP5521 LEDs in the device tree In-Reply-To: References: <1369210331-18545-1-git-send-email-linus.walleij@stericsson.com> <20130603081805.GC3370@gmail.com> Message-ID: <20130604073507.GL3370@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 03 Jun 2013, Bryan Wu wrote: > On Mon, Jun 3, 2013 at 1:18 AM, Lee Jones wrote: > > On Fri, 31 May 2013, Bryan Wu wrote: > > > >> On Wed, May 22, 2013 at 1:12 AM, Linus Walleij > >> wrote: > >> > From: Linus Walleij > >> > > >> > Based on pending device tree support in the LP55xx drivers > >> > we can add the correct LED and channel configuration from the > >> > ux500 device tree for all HREF variants. > >> > > >> > Cc: Milo Kim > >> > Cc: Bryan Wu > >> > Signed-off-by: Linus Walleij > >> > --- > >> > arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------ > >> > 1 file changed, 32 insertions(+), 6 deletions(-) > >> > > >> > diff --git a/arch/arm/boot/dts/href.dtsi b/arch/arm/boot/dts/href.dtsi > >> > index 62523f6..e315429 100644 > >> > --- a/arch/arm/boot/dts/href.dtsi > >> > +++ b/arch/arm/boot/dts/href.dtsi > >> > @@ -63,16 +63,42 @@ > >> > }; > >> > > >> > i2c at 80128000 { > >> > - lp5521 at 0x33 { > >> > - compatible = "lp5521"; > >> > + lp5521 at 33 { > >> > >> Is this right, I guess it should be still "lp5521 at 0x33", although it's > >> just a name. > > > > What makes you say that Bryan? > > > > All other nodes drop the '0x', as it's implied. > > > > But I still got this in this patch > " bh1780 at 0x29 {" > > which is not changed. So which one should be the right? The one without the '0x' is correct. If there are any of these left over that Linus hasn't fixed yet, I'm happy to fix. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] ARM: ux500: register LP5521 LEDs in the device tree Date: Tue, 4 Jun 2013 08:35:07 +0100 Message-ID: <20130604073507.GL3370@gmail.com> References: <1369210331-18545-1-git-send-email-linus.walleij@stericsson.com> <20130603081805.GC3370@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Bryan Wu Cc: Milo Kim , Linus Walleij , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Gabriel Fernandez , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org T24gTW9uLCAwMyBKdW4gMjAxMywgQnJ5YW4gV3Ugd3JvdGU6Cgo+IE9uIE1vbiwgSnVuIDMsIDIw MTMgYXQgMToxOCBBTSwgTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4gd3JvdGU6Cj4g PiBPbiBGcmksIDMxIE1heSAyMDEzLCBCcnlhbiBXdSB3cm90ZToKPiA+Cj4gPj4gT24gV2VkLCBN YXkgMjIsIDIwMTMgYXQgMToxMiBBTSwgTGludXMgV2FsbGVpago+ID4+IDxsaW51cy53YWxsZWlq QHN0ZXJpY3Nzb24uY29tPiB3cm90ZToKPiA+PiA+IEZyb206IExpbnVzIFdhbGxlaWogPGxpbnVz LndhbGxlaWpAbGluYXJvLm9yZz4KPiA+PiA+Cj4gPj4gPiBCYXNlZCBvbiBwZW5kaW5nIGRldmlj ZSB0cmVlIHN1cHBvcnQgaW4gdGhlIExQNTV4eCBkcml2ZXJzCj4gPj4gPiB3ZSBjYW4gYWRkIHRo ZSBjb3JyZWN0IExFRCBhbmQgY2hhbm5lbCBjb25maWd1cmF0aW9uIGZyb20gdGhlCj4gPj4gPiB1 eDUwMCBkZXZpY2UgdHJlZSBmb3IgYWxsIEhSRUYgdmFyaWFudHMuCj4gPj4gPgo+ID4+ID4gQ2M6 IE1pbG8gS2ltIDxNaWxvLktpbUB0aS5jb20+Cj4gPj4gPiBDYzogQnJ5YW4gV3UgPGNvb2xvbmV5 QGdtYWlsLmNvbT4KPiA+PiA+IFNpZ25lZC1vZmYtYnk6IExpbnVzIFdhbGxlaWogPGxpbnVzLndh bGxlaWpAbGluYXJvLm9yZz4KPiA+PiA+IC0tLQo+ID4+ID4gIGFyY2gvYXJtL2Jvb3QvZHRzL2hy ZWYuZHRzaSB8IDM4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tCj4gPj4g PiAgMSBmaWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gPj4g Pgo+ID4+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2hyZWYuZHRzaSBiL2FyY2gv YXJtL2Jvb3QvZHRzL2hyZWYuZHRzaQo+ID4+ID4gaW5kZXggNjI1MjNmNi4uZTMxNTQyOSAxMDA2 NDQKPiA+PiA+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2hyZWYuZHRzaQo+ID4+ID4gKysrIGIv YXJjaC9hcm0vYm9vdC9kdHMvaHJlZi5kdHNpCj4gPj4gPiBAQCAtNjMsMTYgKzYzLDQyIEBACj4g Pj4gPiAgICAgICAgICAgICAgICAgfTsKPiA+PiA+Cj4gPj4gPiAgICAgICAgICAgICAgICAgaTJj QDgwMTI4MDAwIHsKPiA+PiA+IC0gICAgICAgICAgICAgICAgICAgICAgIGxwNTUyMUAweDMzIHsK PiA+PiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJscDU1 MjEiOwo+ID4+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgbHA1NTIxQDMzIHsKPiA+Pgo+ID4+ IElzIHRoaXMgcmlnaHQsIEkgZ3Vlc3MgaXQgc2hvdWxkIGJlIHN0aWxsICJscDU1MjFAMHgzMyIs IGFsdGhvdWdoIGl0J3MKPiA+PiBqdXN0IGEgbmFtZS4KPiA+Cj4gPiBXaGF0IG1ha2VzIHlvdSBz YXkgdGhhdCBCcnlhbj8KPiA+Cj4gPiBBbGwgb3RoZXIgbm9kZXMgZHJvcCB0aGUgJzB4JywgYXMg aXQncyBpbXBsaWVkLgo+ID4KPiAKPiBCdXQgSSBzdGlsbCBnb3QgdGhpcyBpbiB0aGlzIHBhdGNo Cj4gIiAgYmgxNzgwQDB4MjkgeyIKPiAKPiB3aGljaCBpcyBub3QgY2hhbmdlZC4gU28gd2hpY2gg b25lIHNob3VsZCBiZSB0aGUgcmlnaHQ/CgpUaGUgb25lIHdpdGhvdXQgdGhlICcweCcgaXMgY29y cmVjdC4KCklmIHRoZXJlIGFyZSBhbnkgb2YgdGhlc2UgbGVmdCBvdmVyIHRoYXQgTGludXMgaGFz bid0IGZpeGVkIHlldCwgSSdtCmhhcHB5IHRvIGZpeC4KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNU LUVyaWNzc29uIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNv ZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBC bG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRldmlj ZXRyZWUtZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNldHJlZS1kaXNjdXNzQGxpc3RzLm96bGFi cy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2RldmljZXRyZWUtZGlzY3Vz cwo=