From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?iso-8859-1?q?St=FCbner?=) Date: Tue, 4 Jun 2013 09:57:27 +0200 Subject: [PATCH 3/3] clocksource: dw_apb_timer_of: use clocksource_of_init In-Reply-To: <20130604043620.GU11798@tarshish> References: <201306032157.40488.heiko@sntech.de> <201306032159.55685.heiko@sntech.de> <20130604043620.GU11798@tarshish> Message-ID: <201306040957.27920.heiko@sntech.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Dienstag, 4. Juni 2013, 06:36:20 schrieb Baruch Siach: > Hi Heiko, > > On Mon, Jun 03, 2013 at 09:59:55PM +0200, Heiko St?bner wrote: > > dw_apb_timer_init used to search the devicetree for matching timer > > devices, making calls to it from board files necessary. > > > > Change the dw_apb_timer_init to work with CLOCKSOURCE_OF_DECLARE. > > With this change the function gets called once for each timer node > > and tracks these number of calls to attach clockevent and clocksource > > devices to the nodes. > > > > Also remove the calls to dw_apb_timer_init from all previous users, as > > clocksource_of_init is the default for init_time now. > > > > Tested on the upcoming rk3066 code. > > > > Signed-off-by: Heiko Stuebner > > Acked-by: Rob Herring > > Acked-by: Arnd Bergmann > > --- > > > > arch/arm/mach-picoxcell/Kconfig | 1 + > > arch/arm/mach-picoxcell/common.c | 2 - > > arch/arm/mach-socfpga/Kconfig | 1 + > > arch/arm/mach-socfpga/socfpga.c | 2 - > > drivers/clocksource/dw_apb_timer_of.c | 41 > > ++++++++++++++++----------------- include/linux/dw_apb_timer.h > > | 1 - > > 6 files changed, 22 insertions(+), 26 deletions(-) > > > > diff --git a/arch/arm/mach-picoxcell/Kconfig > > b/arch/arm/mach-picoxcell/Kconfig index 13bae78..3ef6bbe 100644 > > --- a/arch/arm/mach-picoxcell/Kconfig > > +++ b/arch/arm/mach-picoxcell/Kconfig > > @@ -6,6 +6,7 @@ config ARCH_PICOXCELL > > > > select CPU_V6K > > select DW_APB_TIMER > > select DW_APB_TIMER_OF > > > > + select CLKSRC_OF > > Shouldn't DW_APB_TIMER 'select CLKSRC_OF if OF' instead of selecting is for > each and every platform? While at it we can do the same to DW_APB_TIMER_OF. if anything DW_APB_TIMER_OF should select both DW_APB_TIMER and 'CLKSRC_OF if OF', as the base DW_APB_TIMER_OF is the platform glue, that uses DW_APB_TIMER internally. But otherwise sounds sensible to not duplicate these selects everywhere. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?iso-8859-1?q?St=FCbner?= Subject: Re: [PATCH 3/3] clocksource: dw_apb_timer_of: use clocksource_of_init Date: Tue, 4 Jun 2013 09:57:27 +0200 Message-ID: <201306040957.27920.heiko@sntech.de> References: <201306032157.40488.heiko@sntech.de> <201306032159.55685.heiko@sntech.de> <20130604043620.GU11798@tarshish> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20130604043620.GU11798@tarshish> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Baruch Siach Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , John Stultz , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Grant Likely , Jamie Iles , Thomas Gleixner List-Id: devicetree@vger.kernel.org Am Dienstag, 4. Juni 2013, 06:36:20 schrieb Baruch Siach: > Hi Heiko, > = > On Mon, Jun 03, 2013 at 09:59:55PM +0200, Heiko St=FCbner wrote: > > dw_apb_timer_init used to search the devicetree for matching timer > > devices, making calls to it from board files necessary. > > = > > Change the dw_apb_timer_init to work with CLOCKSOURCE_OF_DECLARE. > > With this change the function gets called once for each timer node > > and tracks these number of calls to attach clockevent and clocksource > > devices to the nodes. > > = > > Also remove the calls to dw_apb_timer_init from all previous users, as > > clocksource_of_init is the default for init_time now. > > = > > Tested on the upcoming rk3066 code. > > = > > Signed-off-by: Heiko Stuebner > > Acked-by: Rob Herring > > Acked-by: Arnd Bergmann > > --- > > = > > arch/arm/mach-picoxcell/Kconfig | 1 + > > arch/arm/mach-picoxcell/common.c | 2 - > > arch/arm/mach-socfpga/Kconfig | 1 + > > arch/arm/mach-socfpga/socfpga.c | 2 - > > drivers/clocksource/dw_apb_timer_of.c | 41 > > ++++++++++++++++----------------- include/linux/dw_apb_timer.h = > > | 1 - > > 6 files changed, 22 insertions(+), 26 deletions(-) > > = > > diff --git a/arch/arm/mach-picoxcell/Kconfig > > b/arch/arm/mach-picoxcell/Kconfig index 13bae78..3ef6bbe 100644 > > --- a/arch/arm/mach-picoxcell/Kconfig > > +++ b/arch/arm/mach-picoxcell/Kconfig > > @@ -6,6 +6,7 @@ config ARCH_PICOXCELL > > = > > select CPU_V6K > > select DW_APB_TIMER > > select DW_APB_TIMER_OF > > = > > + select CLKSRC_OF > = > Shouldn't DW_APB_TIMER 'select CLKSRC_OF if OF' instead of selecting is f= or > each and every platform? While at it we can do the same to DW_APB_TIMER_O= F. if anything DW_APB_TIMER_OF should select both DW_APB_TIMER and 'CLKSRC_OF = if = OF', as the base DW_APB_TIMER_OF is the platform glue, that uses DW_APB_TIM= ER = internally. But otherwise sounds sensible to not duplicate these selects everywhere. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760119Ab3FDH5o (ORCPT ); Tue, 4 Jun 2013 03:57:44 -0400 Received: from gloria.sntech.de ([95.129.55.99]:56633 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759738Ab3FDH5j (ORCPT ); Tue, 4 Jun 2013 03:57:39 -0400 From: Heiko =?iso-8859-1?q?St=FCbner?= To: Baruch Siach Subject: Re: [PATCH 3/3] clocksource: dw_apb_timer_of: use clocksource_of_init Date: Tue, 4 Jun 2013 09:57:27 +0200 User-Agent: KMail/1.13.7 (Linux/3.2.0-3-686-pae; KDE/4.8.4; i686; ; ) Cc: Jamie Iles , Arnd Bergmann , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , John Stultz , Dinh Nguyen , Grant Likely , Thomas Gleixner , linux-arm-kernel@lists.infradead.org References: <201306032157.40488.heiko@sntech.de> <201306032159.55685.heiko@sntech.de> <20130604043620.GU11798@tarshish> In-Reply-To: <20130604043620.GU11798@tarshish> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Message-Id: <201306040957.27920.heiko@sntech.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 4. Juni 2013, 06:36:20 schrieb Baruch Siach: > Hi Heiko, > > On Mon, Jun 03, 2013 at 09:59:55PM +0200, Heiko Stübner wrote: > > dw_apb_timer_init used to search the devicetree for matching timer > > devices, making calls to it from board files necessary. > > > > Change the dw_apb_timer_init to work with CLOCKSOURCE_OF_DECLARE. > > With this change the function gets called once for each timer node > > and tracks these number of calls to attach clockevent and clocksource > > devices to the nodes. > > > > Also remove the calls to dw_apb_timer_init from all previous users, as > > clocksource_of_init is the default for init_time now. > > > > Tested on the upcoming rk3066 code. > > > > Signed-off-by: Heiko Stuebner > > Acked-by: Rob Herring > > Acked-by: Arnd Bergmann > > --- > > > > arch/arm/mach-picoxcell/Kconfig | 1 + > > arch/arm/mach-picoxcell/common.c | 2 - > > arch/arm/mach-socfpga/Kconfig | 1 + > > arch/arm/mach-socfpga/socfpga.c | 2 - > > drivers/clocksource/dw_apb_timer_of.c | 41 > > ++++++++++++++++----------------- include/linux/dw_apb_timer.h > > | 1 - > > 6 files changed, 22 insertions(+), 26 deletions(-) > > > > diff --git a/arch/arm/mach-picoxcell/Kconfig > > b/arch/arm/mach-picoxcell/Kconfig index 13bae78..3ef6bbe 100644 > > --- a/arch/arm/mach-picoxcell/Kconfig > > +++ b/arch/arm/mach-picoxcell/Kconfig > > @@ -6,6 +6,7 @@ config ARCH_PICOXCELL > > > > select CPU_V6K > > select DW_APB_TIMER > > select DW_APB_TIMER_OF > > > > + select CLKSRC_OF > > Shouldn't DW_APB_TIMER 'select CLKSRC_OF if OF' instead of selecting is for > each and every platform? While at it we can do the same to DW_APB_TIMER_OF. if anything DW_APB_TIMER_OF should select both DW_APB_TIMER and 'CLKSRC_OF if OF', as the base DW_APB_TIMER_OF is the platform glue, that uses DW_APB_TIMER internally. But otherwise sounds sensible to not duplicate these selects everywhere.