All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: P J P <ppandit@redhat.com>
Cc: linux-kernel@vger.kernel.org, Petr Matousek <pmatouse@redhat.com>,
	Vasily Kulikov <segoon@openwall.com>
Subject: Re: [patch] cciss: info leak in cciss_ioctl32_passthru()
Date: Tue, 4 Jun 2013 04:16:41 -0700 (PDT)	[thread overview]
Message-ID: <20130604111640.GE23987@mwanda> (raw)
In-Reply-To: <alpine.LFD.2.03.1306041602160.7145@erqung.pbz>

On Tue, Jun 04, 2013 at 04:09:10PM +0530, P J P wrote:
>    Hello Dan,
> ===
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 6374dc1..34971aa 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1201,6 +1201,7 @@ static int cciss_ioctl32_passthru(struct
> block_device *bdev, fmode_t mode,
>  	int err;
>  	u32 cp;
> 
> +	memset(&arg64, 0, sizeof(arg64));
> 	...
> ===
> 
>   This exact same patch was included back in 2010 by Mr Vasiliy Kulikov.
> 
>  -> https://git.kernel.org/linus/7ab5118d7c2be650bc936894f159dc1c597badae
> 
> But there is no entry/log of its reversal. Any idea why was it removed?

No no.  Vasily patched cciss_ioctl32_big_passthru() and this patch
changes cciss_ioctl32_passthru().

regards,
dan carpenter


  reply	other threads:[~2013-06-04 11:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04 10:39 [patch] cciss: info leak in cciss_ioctl32_passthru() P J P
2013-06-04 11:16 ` Dan Carpenter [this message]
2013-06-04 11:48   ` P J P
  -- strict thread matches above, loose matches on Subject: below --
2013-06-03  9:26 Dan Carpenter
2013-06-03  9:26 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130604111640.GE23987@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmatouse@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=segoon@openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.