From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: grant.likely@linaro.org, rob.herring@calxeda.com,
davem@davemloft.net, sr@denx.de, yongjun_wei@trendmicro.com.cn,
netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH -next] net: sun4i-emac: fix a typo in emac_probe()
Date: Tue, 4 Jun 2013 15:24:08 +0200 [thread overview]
Message-ID: <20130604132408.GD3283@lukather> (raw)
In-Reply-To: <CAPgLHd-fXnt9H_CxDD1Ww=C-6nn3COVkYirKY6ucOJVR2Pkwkw@mail.gmail.com>
Hi,
On Mon, Jun 03, 2013 at 09:36:52PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Just fixed a typo in emac_probe().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/net/ethernet/allwinner/sun4i-emac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c
> index b411344..26083cd 100644
> --- a/drivers/net/ethernet/allwinner/sun4i-emac.c
> +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c
> @@ -821,7 +821,7 @@ static int emac_probe(struct platform_device *pdev)
> db->membase = of_iomap(np, 0);
> if (!db->membase) {
> dev_err(&pdev->dev, "failed to remap registers\n");
> - return -ENOMEM;
> + ret = -ENOMEM;
> goto out;
> }
>
>
Ouch, nice catch.
Thanks!
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
next prev parent reply other threads:[~2013-06-04 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:36 [PATCH -next] net: sun4i-emac: fix a typo in emac_probe() Wei Yongjun
2013-06-03 16:20 ` Joe Perches
2013-06-04 13:24 ` Maxime Ripard [this message]
2013-06-05 0:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604132408.GD3283@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=sr@denx.de \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.