From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915/sdvo: Use &intel_sdvo->ddc instead
 of intel_sdvo->i2c for DDC.
Date: Tue, 4 Jun 2013 17:48:28 +0200
Message-ID: <20130604154828.GD15743@phenom.ffwll.local>
References: <1370358801-305-1-git-send-email-eich@suse.de>
	<20130604153532.GA5398@cantiga.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com
	[209.85.215.172])
	by gabe.freedesktop.org (Postfix) with ESMTP id B8EBAE5EC9
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  4 Jun 2013 08:48:33 -0700 (PDT)
Received: by mail-ea0-f172.google.com with SMTP id q10so342400eaj.3
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 04 Jun 2013 08:48:32 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130604153532.GA5398@cantiga.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Egbert Eich <eich@suse.de>, Daniel Vetter <daniel.vetter@intel.com>, intel-gfx@lists.freedesktop.org, Chris Wilson <chris.wilson@intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Jun 04, 2013 at 04:35:32PM +0100, Chris Wilson wrote:
> On Tue, Jun 04, 2013 at 05:13:21PM +0200, Egbert Eich wrote:
> > In intel_sdvo_get_lvds_modes() the wrong i2c adapter record is used
> > for DDC. Thus the code will always have to rely on a LVDS panel
> > mode supplied by VBT.
> > In most cases this succeeds, so this didn't get detected for quite
> > a while.
> > 
> > Signed-off-by: Egbert Eich <eich@suse.de>
> 
> Good catch!
> Cc: stable@vger.kernel.org
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Yeah, nice catch. If my history digging is correct this has been broken in

commit f899fc64cda8569d0529452aafc0da31c042df2e
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Jul 20 15:44:45 2010 -0700

    drm/i915: use GMBUS to manage i2c links

Patch merged with that note added, thanks.
-Daniel
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch