From: Petr Rockai <mornfall@fedoraproject.org>
To: lvm-devel@redhat.com
Subject: dev-mornfall-activate - pvscan: missing test for id_read_format
Date: Tue, 4 Jun 2013 19:25:51 +0000 (UTC) [thread overview]
Message-ID: <20130604192551.BB8156115D@fedorahosted.org> (raw)
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=dacc340cc89e9be5cb88986a444466edb3a06e52
Commit: dacc340cc89e9be5cb88986a444466edb3a06e52
Parent: f319a61e9c374bd3277deba90216f67fdcb505e9
Author: Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate: Mon Apr 29 12:34:50 2013 +0200
Committer: Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Fri May 3 15:42:44 2013 +0200
pvscan: missing test for id_read_format
(in release fix)
---
tools/pvscan.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tools/pvscan.c b/tools/pvscan.c
index ab58c5f..7c55faa 100644
--- a/tools/pvscan.c
+++ b/tools/pvscan.c
@@ -103,7 +103,9 @@ static int _auto_activation_handler(struct cmd_context *cmd,
if (partial)
return 1;
- id_read_format(&vgid_raw, vgid);
+ if (!id_read_format(&vgid_raw, vgid))
+ return_0;
+
/* NB. This is safe because we know lvmetad is running and we won't hit
* disk. */
if (!(vg = vg_read_internal(cmd, NULL, (const char *) &vgid_raw, 0, &consistent)))
reply other threads:[~2013-06-04 19:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604192551.BB8156115D@fedorahosted.org \
--to=mornfall@fedoraproject.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.