Re: [PATCH v2 0/2] kvm: x86: Emulate MSR_PLATFORM_INFO

[Gleb Natapov <gleb@redhat.com>]

On Tue, Jun 04, 2013 at 12:02:16PM -0400, Bandan Das wrote:
> These patches add an emulated MSR_PLATFORM_INFO that kvm guests
> can read as described in section 14.3.2.4 of the Intel SDM. 
> The relevant changes and details are in [2/2]; [1/2] makes vendor_intel
> generic. There are atleat two known applications that fail to run because
> of this MSR missing - Sandra and vTune.
So I really want Intel opinion on this. Right now it is impossible to
implement the MSR correctly in the face of migration (may be with tsc
scaling it will be possible) and while it is unimplemented if application
tries to use it it fails, but if we will implement it application will
just produce incorrect result without any means for user to detect it.

> 
> v2: Addressed suggested changes
> 
> Bandan Das (2):
>   kvm: make vendor_intel a generic function
>   kvm: x86: emulate MSR_PLATFORM_INFO
> 
>  arch/x86/include/asm/kvm_emulate.h    | 13 ----------
>  arch/x86/include/asm/kvm_host.h       | 20 +++++++++++++++
>  arch/x86/include/uapi/asm/msr-index.h |  2 ++
>  arch/x86/kvm/cpuid.c                  | 19 ++++++++++++++
>  arch/x86/kvm/cpuid.h                  | 16 ++++++++++++
>  arch/x86/kvm/emulate.c                | 16 +++---------
>  arch/x86/kvm/x86.c                    | 48 +++++++++++++++++++++++++++++++++++
>  7 files changed, 109 insertions(+), 25 deletions(-)
> 
> -- 
> 1.8.1.4

--
			Gleb.