From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH v2 0/2] kvm: x86: Emulate MSR_PLATFORM_INFO Date: Wed, 5 Jun 2013 11:42:13 +0300 Message-ID: <20130605084213.GQ4725@redhat.com> References: <1370361738-4277-1-git-send-email-bsd@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Paolo Bonzini , Marcelo Tosatti , "Nakajima, Jun" To: Bandan Das Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7910 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753035Ab3FEImQ (ORCPT ); Wed, 5 Jun 2013 04:42:16 -0400 Content-Disposition: inline In-Reply-To: <1370361738-4277-1-git-send-email-bsd@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jun 04, 2013 at 12:02:16PM -0400, Bandan Das wrote: > These patches add an emulated MSR_PLATFORM_INFO that kvm guests > can read as described in section 14.3.2.4 of the Intel SDM. > The relevant changes and details are in [2/2]; [1/2] makes vendor_intel > generic. There are atleat two known applications that fail to run because > of this MSR missing - Sandra and vTune. So I really want Intel opinion on this. Right now it is impossible to implement the MSR correctly in the face of migration (may be with tsc scaling it will be possible) and while it is unimplemented if application tries to use it it fails, but if we will implement it application will just produce incorrect result without any means for user to detect it. > > v2: Addressed suggested changes > > Bandan Das (2): > kvm: make vendor_intel a generic function > kvm: x86: emulate MSR_PLATFORM_INFO > > arch/x86/include/asm/kvm_emulate.h | 13 ---------- > arch/x86/include/asm/kvm_host.h | 20 +++++++++++++++ > arch/x86/include/uapi/asm/msr-index.h | 2 ++ > arch/x86/kvm/cpuid.c | 19 ++++++++++++++ > arch/x86/kvm/cpuid.h | 16 ++++++++++++ > arch/x86/kvm/emulate.c | 16 +++--------- > arch/x86/kvm/x86.c | 48 +++++++++++++++++++++++++++++++++++ > 7 files changed, 109 insertions(+), 25 deletions(-) > > -- > 1.8.1.4 -- Gleb.