From: Martin Jansa <martin.jansa@gmail.com>
To: Yi Zhao <yi.zhao@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] kernel.bbclass: Fix link for modules-${MACHINE}.tgz
Date: Wed, 5 Jun 2013 12:05:59 +0200 [thread overview]
Message-ID: <20130605100559.GE30727@jama> (raw)
In-Reply-To: <d26bc9ddb088a29796402194ab5649cfbf916248.1370414193.git.yi.zhao@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]
On Wed, Jun 05, 2013 at 05:20:50PM +0800, Yi Zhao wrote:
> The modules-${MACHINE}.tgz should link to ${MODULE_TARBALL_BASE_NAME}.
> But now it links to an invalid file ${MODULE_TARBALL_BASE_NAME}.bin.
> Remove the extra .bin suffix.
>
> [YOCTO #4595]
Looks good, thanks for fixing it.
Acked-by: Martin Jansa <Martin.Jansa@gmail.com>
>
> Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
> ---
> meta/classes/kernel.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 6550615..40a6b5b 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -375,7 +375,7 @@ kernel_do_deploy() {
> if [ ${MODULE_TARBALL_DEPLOY} = "1" ] && (grep -q -i -e '^CONFIG_MODULES=y$' .config); then
> mkdir -p ${D}/lib
> tar -cvzf ${DEPLOYDIR}/${MODULE_TARBALL_BASE_NAME} -C ${D} lib
> - ln -sf ${MODULE_TARBALL_BASE_NAME}.bin ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
> + ln -sf ${MODULE_TARBALL_BASE_NAME} ${DEPLOYDIR}/${MODULE_TARBALL_SYMLINK_NAME}
> fi
>
> ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${DEPLOYDIR}/${KERNEL_IMAGE_SYMLINK_NAME}.bin
> --
> 1.7.9.5
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2013-06-05 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 9:20 [PATCH 0/1] kernel.bbclass: Fix link for modules-${MACHINE}.tgz Yi Zhao
2013-06-05 9:20 ` [PATCH 1/1] " Yi Zhao
2013-06-05 10:05 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605100559.GE30727@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=yi.zhao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.