From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 5/9] drm/i915: Drop overlay DPMS call from
 valleyview_crtc_enable
Date: Wed, 5 Jun 2013 22:49:38 +0300
Message-ID: <20130605194938.GJ5004@intel.com>
References: <1370342947-20757-1-git-send-email-ville.syrjala@linux.intel.com>
	<1370342947-20757-6-git-send-email-ville.syrjala@linux.intel.com>
	<CABVU7+uscUa5ZuF1Gs_UXLO+=1qvZyX15onfA4M3sSLkfRjL=g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id AE260E5CE2
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  5 Jun 2013 12:49:41 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CABVU7+uscUa5ZuF1Gs_UXLO+=1qvZyX15onfA4M3sSLkfRjL=g@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jun 05, 2013 at 04:27:25PM -0300, Rodrigo Vivi wrote:
> just curious/trying to learn more: how do you know it doesn't have?

Because the hardware designers hate me and don't want to give me nice
toys :)

Seriously though, the spec doesn't have it so I have to assume it's
really gone. And we got the sprite planes in exchange. Not the best
trade in my opinion, but what can you do.

> =

> but if it doesn't feel free to use:
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> =

> On Tue, Jun 4, 2013 at 7:49 AM,  <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> >
> > VLV doesn't have the old video overlay.
> >
> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i91=
5/intel_display.c
> > index dac2db7..61bee12 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -3619,9 +3619,6 @@ static void valleyview_crtc_enable(struct drm_crt=
c *crtc)
> >         intel_enable_plane(dev_priv, plane, pipe);
> >         intel_crtc_update_cursor(crtc, true);
> >
> > -       /* Give the overlay scaler a chance to enable if it's on this p=
ipe */
> > -       intel_crtc_dpms_overlay(intel_crtc, true);
> > -
> >         intel_update_fbc(dev);
> >
> >         mutex_unlock(&dev_priv->dpio_lock);
> > --
> > 1.8.1.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> =

> =

> =

> -- =

> Rodrigo Vivi
> Blog: http://blog.vivi.eng.br

-- =

Ville Syrj=E4l=E4
Intel OTC